Bug 2224325: Add checks to ensure existing PVC matches PVC to restore #117
Conversation
Currently, the check for existing PVC, if found during PVC restore, checks to see if PVC exists and is restored by Ramen. This is insufficient in the case of a StatefulSet where the PVC maybe left behind (similar to the PV) post a failover or a relocate and on restore of the PVC if the older PVC is found, it may not be restored by Ramen. The checks for existing PVCs is hence expanded to ensure: - PVC is not deleted - PVC is bound - PVC is bound to the same PV volume name we would have restored The above ensures that we would have restored the same PVC and it would have been bound to the PV as desired. Also, the check to ensure that if the PVC exists it is restored by Ramen is dropped, as that may fail in cases as mentioned above. Signed-off-by: Shyamsundar Ranganathan <[email protected]> (cherry picked from commit 1805b30)
Attempting to improve code quality as changes are done around the code. In this case adding comments to related functions. Signed-off-by: Shyamsundar Ranganathan <[email protected]> (cherry picked from commit ce7fe03)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ShyamsundarR The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ShyamsundarR: This pull request references Bugzilla bug 2224325, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 2 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: parikshithb. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ShyamsundarR: All pull requests linked via external trackers have merged: Bugzilla bug 2224325 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently, the check for existing PVC, if found during PVC restore, checks to see if PVC exists and is restored by Ramen.
This is insufficient in the case of a StatefulSet where the PVC maybe left behind (similar to the PV) post a failover or a relocate and on restore of the PVC if the older PVC is found, it may not be restored by Ramen.
The checks for existing PVCs is hence expanded to ensure:
The above ensures that we would have restored the same PVC and it would have been bound to the PV as desired.
Also, the check to ensure that if the PVC exists it is restored by Ramen is dropped, as that may fail in cases as mentioned above.