Description text change for manage policy modal #970
Conversation
GowthamShanmugam
changed the title
GowthamShanmugam
force-pushed
the
bz_2231838
branch
3 times, most recently
from
3ed19a9
to
a1d1606
Compare
|
|
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
a1d1606
to
5cf7248
Compare
| @@ -184,39 +195,59 @@ export const PolicyListView: React.FC<PolicyListViewProps> = ({ | |||
| setModalActionContext={setModalActionContext} | |||
| setMessage={setMessage} | |||
| isActionHidden | |||
| isSearchHidden={!dataPolicyInfo.length} | |||
There was a problem hiding this comment.
do we need to pass this prop... can we do something like this ??
dataPolicyInfo.length === 0 ? EmptyState : PolicyListViewToolBar
There was a problem hiding this comment.
PolicyListViewToolBar has other items, like the subtitle and assign policy buttons. Search box is one part of PolicyListViewToolBar
| emptyRowMessage={() => ( | ||
| <Bullseye> {t('No assigned data policy found')} </Bullseye> | ||
| )} |
There was a problem hiding this comment.
just a doubt:
we are checking dataPolicyInfo.length === 0 in policy-list-view.tsx file and accordingly displaying table... do we need to pass it here again ??
Is it just for extra safety ??
There was a problem hiding this comment.
dataPolicyInfo is unfiltered, This one is for filtering.
dataPolicyInfo.length === 0 is for, till now no policy is assigned to the application.
This one is for, policy is assigned but for search text, no matching found.
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
5cf7248
to
99780f0
Compare
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
99780f0
to
66ecd03
Compare
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
66ecd03
to
8d23ec8
Compare
|
/lgtm |
|
/cherry-pick release-4.14 |
|
@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.14-compatibility |
|
@GowthamShanmugam: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @SanjalKatiyar for approval |
|
@GowthamShanmugam: GitHub didn't allow me to assign the following users: for, approval. Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
8d23ec8
to
5dcae95
Compare
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
5dcae95
to
b192d89
Compare
Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
GowthamShanmugam
force-pushed
the
bz_2231838
branch
from
b192d89
to
39b17b6
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 6085a42
into
red-hat-storage:master
|
@GowthamShanmugam: new pull request created: #989 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@GowthamShanmugam: new pull request created: #990 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2231838