Policy configuration view for application #903

GowthamShanmugam · 2023-06-19T16:11:10Z

On top of #894

GowthamShanmugam · 2023-06-20T11:42:38Z

Screencast.from.2023-07-04.15-36-53.webm

bipuladh · 2023-06-28T09:29:13Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

@@ -61,7 +68,7 @@ export const AppManagePoliciesModal: React.FC<AppManagePoliciesModalProps> = ({
      onClose={close}
    >
      {loaded && !loadError ? (
-        state.modalViewContext === ModalViewContext.POLICY_LIST_VIEW && (
+        (state.modalViewContext === ModalViewContext.POLICY_LIST_VIEW && (


This could be a component by itself. We could pass all the props to one component and based on on the modalViewContext it would use the right component.

bipuladh · 2023-06-28T09:29:38Z

packages/mco/components/modals/app-manage-policies/helper/messages.tsx

  [
    ModalActionContext.UN_ASSIGN_POLICIES_SUCCEEDED,
    ModalActionContext.UN_ASSIGN_POLICIES_FAILED,
+    ModalActionContext.UN_ASSIGN_POLICY_SUCCEEDED,


Suggested change

ModalActionContext.UN_ASSIGN_POLICY_SUCCEEDED,

ModalActionContext.UNASSIGN_POLICY_SUCCEEDED,

nit

bipuladh · 2023-06-28T09:32:09Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+            id="placement-control-view-dropdown"
+            selectedKey={selected}
+            isDisabled={isDisabledSelector}
+            selectOptions={dropdownOptions(


dropdownOptions are getting recreated every re-render move it out to a variable.

bipuladh · 2023-06-28T09:32:58Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+            onChange={(value: string) => {
+              setSelected(value);
+              onSelect(value);
+            }}


Move it out to a function.

bipuladh · 2023-06-28T09:33:10Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+              setSelected(value);
+              onSelect(value);
+            }}
+            className="mco-manage-policies__dropdown--width"


Suggested change

className="mco-manage-policies__dropdown--width"

className="mco-manage-policies__dropdown--wide"

Modifier should be an adjective.

bipuladh · 2023-06-28T09:37:48Z

packages/mco/components/modals/app-manage-policies/style.scss

@@ -11,4 +11,7 @@
        justify-content: space-between;
        padding: 0 var(--pf-global--spacer--md) 0 var(--pf-global--spacer--md);
    }
+    &__dropdown--width {
+        min-width: 15rem;


Can we use PF global spacers?

PF global spacers has upto 4x which is 5rem

bipuladh · 2023-06-28T09:39:37Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+  placementControlInfo: PlacementControlProps,
+  selected: string,
+  isDefaultSelected: boolean
+) =>


Please add return types.

bipuladh · 2023-06-28T09:40:08Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+};
+
+export type PlacementControlProps = {
+  [placementName in string]: {


Suggested change

[placementName in string]: {

[placementName: string]: {

bipuladh · 2023-06-28T09:40:56Z

packages/mco/components/modals/app-manage-policies/unassign-policy-view.tsx

+    {}
+  );
+
+const generatefooterButtons = (props: FooterProps): FooterButtonProps => ({


Suggested change

const generatefooterButtons = (props: FooterProps): FooterButtonProps => ({

const generatefooterButtons = ({t, onBack}): FooterButtonProps => ({

bipuladh · 2023-06-28T09:42:28Z

packages/mco/components/modals/app-manage-policies/unassign-policy-view.tsx

+        <Messages state={state} />
+      </ModalBody>
+      <ModalFooter>
+        {generatefooterButtons({


GenerateFooterButtons should be a component. This essentially recreates your components everytime in a re-render.

SanjalKatiyar · 2023-06-30T13:21:24Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

+    (state.modalViewContext === ModalViewContext.POLICY_LIST_VIEW && (
+      <PolicyListView
+        dataPolicyInfo={applicaitonInfo?.dataPolicies}
+        state={state.policyListView}
+        dispatch={dispatch}
+        setModalContext={setModalContext}
+        setModalActionContext={setModalActionContext}
+        setMessage={setMessage}
+      />
+    )) ||
+    (state.modalViewContext === ModalViewContext.UNASSIGN_POLICY_VIEW && (
+      <UnAssignPolicyView
+        state={state.unAssignPolicyView}
+        dispatch={dispatch}
+        setModalContext={setModalContext}
+        setModalActionContext={setModalActionContext}
+        setMessage={setMessage}
+      />
+    ))
+  );


nits (to save OR/AND conditions):

Suggested change

(state.modalViewContext === ModalViewContext.POLICY_LIST_VIEW && (

<PolicyListView

dataPolicyInfo={applicaitonInfo?.dataPolicies}

state={state.policyListView}

dispatch={dispatch}

setModalContext={setModalContext}

setModalActionContext={setModalActionContext}

setMessage={setMessage}

/>

)) ||

(state.modalViewContext === ModalViewContext.UNASSIGN_POLICY_VIEW && (

<UnAssignPolicyView

state={state.unAssignPolicyView}

dispatch={dispatch}

setModalContext={setModalContext}

setModalActionContext={setModalActionContext}

setMessage={setMessage}

/>

))

);

{

{

[ModalViewContext.POLICY_LIST_VIEW]: (

<PolicyListView

dataPolicyInfo={applicaitonInfo?.dataPolicies}

state={state.policyListView}

dispatch={dispatch}

setModalContext={setModalContext}

setModalActionContext={setModalActionContext}

setMessage={setMessage}

/>

),

[ModalViewContext.UNASSIGN_POLICY_VIEW ]: (

<UnAssignPolicyView

state={state.unAssignPolicyView}

dispatch={dispatch}

setModalContext={setModalContext}

setModalActionContext={setModalActionContext}

setMessage={setMessage}

/>

),

}[state.modalViewContext]

}

switch case in JSX...

SanjalKatiyar · 2023-06-30T13:27:27Z

Screencast.from.2023-06-20.17-11-11.webm

isn't "View config" and "Unassign" opening exactly same UI, only diff is that in latter we have an extra button to un-assign the policy/policies ?? can't we have single UI for both, in "Unassign" page they can view details as well IMO.

we might not want to change UX at this point of time, still asking in case there was any specific reason for that ??

SanjalKatiyar · 2023-06-30T13:33:17Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

@@ -0,0 +1,238 @@
+import * as React from 'react';
+import { pluralize } from '@odf/core/components/utils';


mco was only supposed to be dependant upon @odf/shared not on @odf/core (as per dependencies in package.json of mco)...

but anyway I can see multiple such imports in mco from @odf/core, so guess no point to make any change for this in the PR...

SanjalKatiyar · 2023-06-30T13:46:36Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+): string[] =>
+  isDefaultSelected
+    ? // Aggregate all labels
+      Object.values(placementControlInfo)?.reduce(


we are overusing ?. everywhere (in general in mco)... we can keep default value of placementControlInfo as {} and avoid using ?. here...
same is true for other places as well, where it is possible to handle the cases like that...

Suggested change

Object.values(placementControlInfo)?.reduce(

Object.values(placementControlInfo).reduce(

MCO is a parser logic, The problem here is, We are not reading one exact CR type. We are grouping one CR based on another, So the entire CR can be optional here. It may come or may not, so it is difficult for us to decide on an object type as these fields are mandatory and these fields are optional. or we need to declare all types with actual CR type | {}

i will try to re-evaluate on this PR, i will check and remove it any unnecessary options symbol used

SanjalKatiyar · 2023-06-30T13:48:31Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+  placementControls?.reduce(
+    (acc, drpc) => ({
+      ...acc,
+      [getName(drpc?.placementInfo)]: drpc,
+    }),
+    {}
+  );


Suggested change

placementControls?.reduce(

(acc, drpc) => ({

...acc,

[getName(drpc?.placementInfo)]: drpc,

}),

{}

);

placementControls?.reduce(

(acc, drpc) => ({

...acc,

[getName(drpc?.placementInfo)]: drpc,

}),

{}

) || {};

SanjalKatiyar · 2023-06-30T13:51:00Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+export const DataPolicyStatus: React.FC<DataPolicyStatusProps> = ({
+  isValidated,
+  t,
+}) => {
+  return (
+    <StatusIconAndText
+      {...(isValidated
+        ? { title: t('Validated'), icon: <GreenCheckCircleIcon /> }
+        : {
+            title: t('Not Validated'),
+            icon: <RedExclamationCircleIcon />,
+          })}
+    />
+  );
+};


do we need to create a separate FC for this ?? It is just adding props...

We are using this in more than one place, I did this to reuse the same code.

SanjalKatiyar · 2023-06-30T13:56:17Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+    <div className="mco-manage-policies__row--padding">
+      <div className="mco-manage-policies__header">
+        <Text component="h3"> {t('Policy configuration details')} </Text>
+        {!!Object.keys(placementControlMap)?.length && (


Suggested change

{!!Object.keys(placementControlMap)?.length && (

{!!Object.keys(placementControlMap).length && (

SanjalKatiyar · 2023-06-30T13:59:07Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+  const dropdownOptions = React.useMemo(
+    () =>
+      getDropdownOptions(
+        Object.keys(placementControlMap),
+        defaultSelectionText
+      ),
+    [placementControlMap, defaultSelectionText]
+  );


nits: we don;t really need to memoize it, SingleSelectDropdown does need it's ref to be constant...
we can directly pass selectOptions={getDropdownOptions(Object.keys(placementControlMap), defaultSelectionText)} as prop...

but only a suggestion, feel free to ignore this comment if want to...

SanjalKatiyar · 2023-06-30T14:00:43Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+  const syncScheduleFormat = {
+    m: t('minutes'),
+    h: t('hours'),
+    d: t('days'),
+  };


we are using this at one more place in mco, can be moved to constants ?

SanjalKatiyar · 2023-06-30T14:03:00Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+            <DescriptionListItem
+              term={t('Application resources protected')}
+              description={pluralize(
+                Object.keys(placementControlMap)?.length,


Suggested change

Object.keys(placementControlMap)?.length,

Object.keys(placementControlMap).length,

SanjalKatiyar · 2023-06-30T14:04:50Z

packages/mco/components/modals/app-manage-policies/parsers/application-set-parser.tsx

@@ -97,7 +98,7 @@ const generateDRPlacementControlInfo = (
          metadata: drpc.metadata,
          drPolicyRef: drpc.spec.drPolicyRef,
          placementInfo: plsInfo,
-          pvcSelector: drpc.spec?.pvcSelector,
+          pvcSelector: arrayify(drpc?.spec?.pvcSelector?.matchLabels) || [],


do we need ?. at every level ??

no need, only for drpc is fine

SanjalKatiyar · 2023-06-30T14:05:47Z

packages/shared/dropdown/singleselectdropdown.tsx

@@ -44,6 +44,7 @@ export const SingleSelectDropdown: React.FC<SingleSelectDropdownProps> = ({
        placeholderText={props?.placeholderText || t('Select options')}
        aria-labelledby={props?.id}
        noResultsFoundText={t('No results found')}
+        isDisabled={props?.isDisabled}


no need...

Suggested change

isDisabled={props?.isDisabled}

we are already doing {...props} above, so just pass isDisabled to SingleSelectDropdown and it will pass it down to Select.

SanjalKatiyar · 2023-06-30T14:08:35Z

packages/shared/labels/labels.tsx

+  labels,
+  collapsedText,
+  expandedText,
+  numLabels,
+  className,


Suggested change

labels,

collapsedText,

expandedText,

numLabels,

className,

labels,

labelClassName,

...props

SanjalKatiyar · 2023-06-30T14:08:51Z

packages/shared/labels/labels.tsx

+      numLabels={numLabels}
+      expandedText={expandedText}
+      collapsedText={collapsedText}


Suggested change

numLabels={numLabels}

expandedText={expandedText}

collapsedText={collapsedText}

{...props}

SanjalKatiyar · 2023-06-30T14:09:08Z

packages/shared/labels/labels.tsx

+      collapsedText={collapsedText}
+    >
+      {labels.map((label) => (
+        <Label key={label} className={className} isTruncated>


Suggested change

<Label key={label} className={className} isTruncated>

<Label key={label} className={labelClassName} isTruncated>

SanjalKatiyar · 2023-06-30T14:09:30Z

packages/shared/labels/labels.tsx

+  /** Customizable "Show Less" text string */
+  collapsedText?: string;
+  /** Customizeable template string. Use variable "${remaining}" for the overflow label count. */
+  expandedText?: string;
+  /** Set number of labels to show before overflow */
+  numLabels?: number;


Suggested change

/** Customizable "Show Less" text string */

collapsedText?: string;

/** Customizeable template string. Use variable "${remaining}" for the overflow label count. */

expandedText?: string;

/** Set number of labels to show before overflow */

numLabels?: number;

SanjalKatiyar · 2023-06-30T14:21:01Z

packages/mco/components/modals/app-manage-policies/unassign-policy-view.tsx

+  return modalActionContext === ModalActionContext.UN_ASSIGNING_POLICY ? (
+    <>
+      <Button
+        id="modal-cancel-action"
+        variant={ButtonVariant.secondary}
+        onClick={onCancel}
+      >
+        {t('Cancel')}
+      </Button>
+      <Button
+        id="modal-confirm-action"
+        variant={ButtonVariant.primary}
+        onClick={unAssignPolicy}
+        isLoading={isButtonLoading}
+      >
+        {t('Confirm')}
+      </Button>
+    </>
+  ) : (
+    <>
+      <Button
+        id="modal-back-action"
+        variant={ButtonVariant.secondary}
+        onClick={onBack}
+      >
+        {t('Back')}
+      </Button>
+      <Button
+        id="modal-unassign-action"
+        variant={ButtonVariant.primary}
+        onClick={onUnassign}
+      >
+        {isAllSelected ? t('Unassign for all') : t('Unassign')}
+      </Button>
+    </>
+  );
+};


nits (but feel free to ignore this comment if want to):

Suggested change

return modalActionContext === ModalActionContext.UN_ASSIGNING_POLICY ? (

<>

<Button

id="modal-cancel-action"

variant={ButtonVariant.secondary}

onClick={onCancel}

>

{t('Cancel')}

</Button>

<Button

id="modal-confirm-action"

variant={ButtonVariant.primary}

onClick={unAssignPolicy}

isLoading={isButtonLoading}

>

{t('Confirm')}

</Button>

</>

) : (

<>

<Button

id="modal-back-action"

variant={ButtonVariant.secondary}

onClick={onBack}

>

{t('Back')}

</Button>

<Button

id="modal-unassign-action"

variant={ButtonVariant.primary}

onClick={onUnassign}

>

{isAllSelected ? t('Unassign for all') : t('Unassign')}

</Button>

</>

);

};

const isContextUnAssign = modalActionContext === ModalActionContext.UN_ASSIGNING_POLICY;

return ? (

<>

<Button

id="modal-cancel-action"

variant={ButtonVariant.secondary}

onClick={isContextUnAssign ? onCancel : onBack}

>

{isContextUnAssign ? t('Cancel') : t('Back')}

</Button>

<Button

id="modal-confirm-action"

variant={ButtonVariant.primary}

onClick={isContextUnAssign ? unAssignPolicy: onUnassign}

isLoading={isButtonLoading}

>

{isContextUnAssign ? ('Confirm') : isAllSelected ? t('Unassign for all') : t('Unassign')}

</Button>

</>

)

};

GowthamShanmugam · 2023-07-04T08:21:42Z

Screencast.from.2023-06-20.17-11-11.webm

isn't "View config" and "Unassign" opening exactly same UI, only diff is that in latter we have an extra button to un-assign the policy/policies ?? can't we have single UI for both, in "Unassign" page they can view details as well IMO.

we might not want to change UX at this point of time, still asking in case there was any specific reason for that ??

It's a single UI only, the only difference is I change the footer using generate footer component.

GowthamShanmugam · 2023-07-04T10:16:22Z

packages/shared/src/utils/common.ts

+) => {
+  const pluralized = `${count === 1 ? singular : plural}`;
+  return includeCount ? `${count || 0} ${pluralized}` : pluralized;
+};


I have created a new pluralize function in shared and referring from here,
later we remove the old pluralize function reference from all places.

bipuladh · 2023-07-06T08:06:34Z

packages/mco/components/disaster-recovery/create-dr-policy/select-replication-type.tsx

  const SCHEDULE_FORMAT = {
-    [SyncScheduleFormat.minutes]: TIME_UNITS.Minutes,
-    [SyncScheduleFormat.hours]: TIME_UNITS.Hours,
-    [SyncScheduleFormat.days]: TIME_UNITS.Days,
+    [SyncScheduleFormat.m]: TIME_UNITS.Minutes,
+    [SyncScheduleFormat.h]: TIME_UNITS.Hours,
+    [SyncScheduleFormat.d]: TIME_UNITS.Days,
  };


this doesn't need to be part of the react component.

bipuladh · 2023-07-06T08:07:10Z

packages/mco/components/disaster-recovery/create-dr-policy/select-replication-type.tsx

  };

  const [isOpen, setIsOpen] = React.useState(false);
  const [selectedFormat, setSelectedFormat] = React.useState(
-    SyncScheduleFormat.minutes
+    SyncScheduleFormat.m


Can we keep it as original to minutes, hours and days? m could be month or minute.

Its a unit from DRPolicy CR, DRPolicy is using d, m, h to represent sync interval, in UI we are mapping
m to minutes
h to hours
d to days

bipuladh · 2023-07-06T08:07:37Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx


-export const AppManagePoliciesModal: React.FC<AppManagePoliciesModalProps> = ({
+export const ModalBody: React.FC<ModalBodyProps> = ({


ModalBody is too generic name. can we make it application specific.

bipuladh · 2023-07-06T08:09:52Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

+    modalActionViewContext: ModalActionContext,
+    modalViewContext?: ModalViewContext


Suggested change

modalActionViewContext: ModalActionContext,

modalViewContext?: ModalViewContext

modalActionContext: ModalActionContext,

modalViewContext?: ModalViewContext

bipuladh · 2023-07-06T08:13:36Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

+    [ModalViewContext.POLICY_LIST_VIEW]: (
+      <PolicyListView
+        dataPolicyInfo={applicaitonInfo?.dataPolicies}
+        state={state.policyListView}
+        dispatch={dispatch}
+        setModalContext={setModalContext}
+        setModalActionContext={setModalActionContext}
+        setMessage={setMessage}
+      />
+    ),
+    [ModalViewContext.POLICY_CONFIGURATON_VIEW]: (
+      <PolicyConfigView
+        state={state.policyConfigurationView}
+        setModalContext={setModalContext}
+      />
+    ),
+  }[state.modalViewContext];


You are creating an object and then passing a key to the object. This will not be stable. You could select a component first based on the value of modalViewContext and then render it.

bipuladh · 2023-07-06T08:16:22Z

packages/mco/components/modals/app-manage-policies/helper/policy-config-viewer.tsx

+  const dropdownOptions = getDropdownOptions(
+    Object.keys(placementControlMap),
+    defaultSelectionText
+  );


Do you want to memoize it?

bipuladh · 2023-07-06T12:03:20Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

  const setModalContext = (modalViewContext: ModalViewContext) => {
    dispatch({
      type: ManagePolicyStateType.SET_MODAL_VIEW_CONTEXT,
      payload: modalViewContext,
    });
  };

-  const setModalActionContext = (modalViewContext: ModalActionContext) =>
+  const setModalActionContext = (


Wrap it in useCallback

bipuladh · 2023-07-06T12:03:31Z

packages/mco/components/modals/app-manage-policies/app-manage-policies-modal.tsx

    });

-  const setMessage = (message: MessageType) => {
+  const setMessage = (


wrap it in useCallback

bipuladh · 2023-07-06T12:05:31Z

packages/mco/components/modals/app-manage-policies/policy-config-view.tsx

+      <ModalBody>
+        <PolicyConfigViewer policy={state.policy} />
+      </ModalBody>
+      <ModalFooter>


We only have one button?

yes one button for back, since we dropped disable DR, i no need other button

SanjalKatiyar · 2023-07-06T12:33:47Z

packages/shared/src/labels/labels.tsx

+export type LabelsProps = LableGroup & {
+  labels: string[];
+  labelClassName?: string;
+};


each directory under src will have an index.ts file which will export the utility, here all export from labels.tsx file...

then there is an index.ts file directly under src need to export from there as well...

SanjalKatiyar · 2023-07-06T12:50:32Z

packages/shared/src/index.ts

@@ -13,6 +13,7 @@ export * from './heading';
 export * from './hooks';
 export * from './input-with-requirements';
 export * from './kebab';
+export * from './labels/labels';


Suggested change

export * from './labels/labels';

export * from './labels';

label directory will also have an index file...

SanjalKatiyar · 2023-07-06T13:09:41Z

packages/shared/src/labels/labels.tsx

@@ -0,0 +1,34 @@
+import * as React from 'react';
+import { Label, LabelGroup } from '@patternfly/react-core';


Suggested change

import { Label, LabelGroup } from '@patternfly/react-core';

import { Label, LabelGroup, LabelGroupProps } from '@patternfly/react-core';

SanjalKatiyar · 2023-07-06T13:09:55Z

packages/shared/src/labels/labels.tsx

+export type LableGroup = {
+  /** Customizable "Show Less" text string */
+  collapsedText?: string;
+  /** Customizeable template string. Use variable "${remaining}" for the overflow label count. */
+  expandedText?: string;
+  /** Set number of labels to show before overflow */
+  numLabels?: number;
+};
+
+export type LabelsProps = LableGroup & {
+  labels: string[];
+  labelClassName?: string;
+};


Suggested change

export type LableGroup = {

/** Customizable "Show Less" text string */

collapsedText?: string;

/** Customizeable template string. Use variable "${remaining}" for the overflow label count. */

expandedText?: string;

/** Set number of labels to show before overflow */

numLabels?: number;

};

export type LabelsProps = LableGroup & {

labels: string[];

labelClassName?: string;

};

export type LabelsProps = LabelGroupProps & {

labels: string[];

labelClassName?: string;

};

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

SanjalKatiyar · 2023-07-06T13:33:19Z

/lgtm

SanjalKatiyar · 2023-07-06T13:34:08Z

/lgtm

cc @bipuladh for approval...

bipuladh · 2023-07-06T15:38:46Z

/approve

openshift-ci · 2023-07-06T15:38:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, GowthamShanmugam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

GowthamShanmugam force-pushed the RHSTOR-4609 branch 2 times, most recently from c162629 to 6dd8516 Compare June 20, 2023 11:40

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 6dd8516 to fc0d502 Compare June 20, 2023 13:37

openshift-merge-robot added the needs-rebase label Jun 21, 2023

GowthamShanmugam force-pushed the RHSTOR-4609 branch from fc0d502 to 6fbd11b Compare June 23, 2023 11:03

openshift-merge-robot removed the needs-rebase label Jun 23, 2023

GowthamShanmugam force-pushed the RHSTOR-4609 branch 3 times, most recently from cb97cea to 3a35a7e Compare June 26, 2023 09:05

agarwal-mudit requested a review from bipuladh June 27, 2023 12:01

bipuladh reviewed Jun 28, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch 2 times, most recently from 935880b to b9c3b33 Compare June 28, 2023 16:46

SanjalKatiyar reviewed Jun 30, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase label Jul 4, 2023

GowthamShanmugam force-pushed the RHSTOR-4609 branch from b9c3b33 to a9e8840 Compare July 4, 2023 10:06

openshift-merge-robot removed the needs-rebase label Jul 4, 2023

GowthamShanmugam changed the title ~~Unassign data policy for application~~ Policy configuration view for application Jul 4, 2023

GowthamShanmugam commented Jul 4, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch from a9e8840 to 010d51c Compare July 4, 2023 10:28

GowthamShanmugam mentioned this pull request Jul 4, 2023

Assign policy wizard #906

Merged

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 010d51c to 919c1a1 Compare July 5, 2023 11:28

bipuladh reviewed Jul 6, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 919c1a1 to 9833a77 Compare July 6, 2023 11:59

bipuladh reviewed Jul 6, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 9833a77 to 55e9c22 Compare July 6, 2023 12:19

SanjalKatiyar reviewed Jul 6, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 55e9c22 to ca39b18 Compare July 6, 2023 12:48

SanjalKatiyar reviewed Jul 6, 2023

View reviewed changes

GowthamShanmugam force-pushed the RHSTOR-4609 branch from ca39b18 to 797d520 Compare July 6, 2023 13:05

SanjalKatiyar reviewed Jul 6, 2023

View reviewed changes

Policy config view for application

b345d5f

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

GowthamShanmugam force-pushed the RHSTOR-4609 branch from 797d520 to b345d5f Compare July 6, 2023 13:31

openshift-ci bot assigned SanjalKatiyar Jul 6, 2023

openshift-ci bot added the lgtm label Jul 6, 2023

openshift-ci bot added the approved label Jul 6, 2023

openshift-merge-robot merged commit 1678c4f into red-hat-storage:master Jul 6, 2023
3 checks passed

	ModalActionContext.UN_ASSIGN_POLICY_SUCCEEDED,
	ModalActionContext.UNASSIGN_POLICY_SUCCEEDED,

	className="mco-manage-policies__dropdown--width"
	className="mco-manage-policies__dropdown--wide"

	const generatefooterButtons = (props: FooterProps): FooterButtonProps => ({
	const generatefooterButtons = ({t, onBack}): FooterButtonProps => ({

		@@ -0,0 +1,238 @@
		import * as React from 'react';
		import { pluralize } from '@odf/core/components/utils';

	Object.values(placementControlInfo)?.reduce(
	Object.values(placementControlInfo).reduce(

	{!!Object.keys(placementControlMap)?.length && (
	{!!Object.keys(placementControlMap).length && (

	Object.keys(placementControlMap)?.length,
	Object.keys(placementControlMap).length,

	<Label key={label} className={className} isTruncated>
	<Label key={label} className={labelClassName} isTruncated>


		export const AppManagePoliciesModal: React.FC<AppManagePoliciesModalProps> = ({
		export const ModalBody: React.FC<ModalBodyProps> = ({

		modalActionViewContext: ModalActionContext,
		modalViewContext?: ModalViewContext

		@@ -0,0 +1,34 @@
		import * as React from 'react';
		import { Label, LabelGroup } from '@patternfly/react-core';

	import { Label, LabelGroup } from '@patternfly/react-core';
	import { Label, LabelGroup, LabelGroupProps } from '@patternfly/react-core';

Policy configuration view for application #903

Policy configuration view for application #903

Conversation

GowthamShanmugam commented Jun 19, 2023 • edited Loading

GowthamShanmugam commented Jun 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Jun 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GowthamShanmugam commented Jul 4, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SanjalKatiyar commented Jul 6, 2023

SanjalKatiyar commented Jul 6, 2023

bipuladh commented Jul 6, 2023

openshift-ci bot commented Jul 6, 2023

GowthamShanmugam commented Jun 19, 2023 •

edited

Loading

GowthamShanmugam commented Jun 20, 2023 •

edited

Loading