Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cypress #1659

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Upgrade Cypress #1659

merged 1 commit into from
Nov 12, 2024
+159 −153

Conversation

aruniiird
Copy link
Contributor

@aruniiird aruniiird commented Nov 7, 2024 •
edited by alfonsomthd
Loading

@aruniiird
Copy link
Contributor Author

@alfonsomthd , @SanjalKatiyar , please take a look...

@aruniiird aruniiird changed the title Upgrading cypress package Upgrading cypress packages Nov 7, 2024
alfonsomthd
alfonsomthd reviewed Nov 7, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@alfonsomthd
Copy link
Collaborator

@aruniiird yarn lint fails with errors like:

/home/runner/work/odf-console/odf-console/cypress/helpers/formValidations.ts
Error: 15:3 error It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from cy. in a next command line cypress/unsafe-to-chain-command
Error: 46:3 error It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from cy. in a next command line cypress/unsafe-to-chain-command
Error: 55:3 error It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from cy. in a next command line cypress/unsafe-to-chain-command
Error: 64:3 error It is unsafe to chain further commands that rely on the subject after this command. It is best to split the chain, chaining again from cy. in a next command line cypress/unsafe-to-chain-command

Those are fixed in #1657

@SanjalKatiyar
Copy link
Collaborator

@aruniiird plz add Jira story to the PR's description.

@alfonsomthd
Copy link
Collaborator

@aruniiird I see this error in E2E job:

Error: Webpack Compilation Error
[tsl] ERROR in /go/src/github.com/red-hat-storage/odf-console/cypress/support.ts(26,17)
TS2339: Property 'defaults' does not exist on type '{ debug(enabled: boolean, options?: Partial): void; }'.
at handle (/go/src/github.com/red-hat-storage/odf-console/node_modules/@cypress/webpack-preprocessor/dist/index.js:212:23)
at finalCallback (/go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:498:32)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:576:17
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/HookWebpackError.js:67:2
at Hook.eval [as callAsync] (eval at create (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at Cache.storeBuildDependencies (/go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Cache.js:126:37)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:572:19
at Hook.eval [as callAsync] (eval at create (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:568:23
at Compiler.emitRecords (/go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:1044:4)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:558:11
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:1007:14
at Hook.eval [as callAsync] (eval at create (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:1004:27
at /go/src/github.com/red-hat-storage/odf-console/node_modules/neo-async/async.js:2818:7
at done (/go/src/github.com/red-hat-storage/odf-console/node_modules/neo-async/async.js:3522:9)
at Hook.eval [as callAsync] (eval at create (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/HookCodeFactory.js:33:10), :6:1)
at Hook.CALL_ASYNC_DELEGATE [as _callAsync] (/go/src/github.com/red-hat-storage/odf-console/node_modules/tapable/lib/Hook.js:18:14)
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/lib/Compiler.js:833:33
at /go/src/github.com/red-hat-storage/odf-console/node_modules/webpack/node_modules/graceful-fs/graceful-fs.js:143:16
at /root/.cache/Cypress/13.15.2/Cypress/resources/app/node_modules/@packages/server/node_modules/graceful-fs/graceful-fs.js:143:16
at /root/.cache/Cypress/13.15.2/Cypress/resources/app/node_modules/@packages/server/node_modules/graceful-fs/graceful-fs.js:143:16
at /root/.cache/Cypress/13.15.2/Cypress/resources/app/node_modules/@packages/server/node_modules/graceful-fs/graceful-fs.js:61:14
at FSReqCallback.oncomplete (node:fs:187:23)

@alfonsomthd alfonsomthd changed the title Upgrading cypress packages Upgrade Cypress Nov 11, 2024
alfonsomthd
alfonsomthd reviewed Nov 11, 2024
View reviewed changes
cypress/cypress.config.ts
@@ -7,6 +7,7 @@ export default defineConfig({
setupNodeEvents,
specPattern: 'cypress/tests/**/*.ts',
supportFile: 'cypress/support.ts',
testIsolation: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should enable this (and refactor accordingly) in a follow-up PR.

@SanjalKatiyar
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Nov 11, 2024
@SanjalKatiyar
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aruniiird, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3499600 into red-hat-storage:master Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd left review comments

Assignees

@SanjalKatiyar SanjalKatiyar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aruniiird @alfonsomthd @SanjalKatiyar @openshift-merge-robot