Bug 2304993: [release-4.17] Optimizing the chunk size using devtool #1534
Conversation
Signed-off-by: Gowtham Shanmugasundaram <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle Bug 2304993: [release-4.17] Optimizing the chunk size using devtool |
openshift-ci
bot
changed the title
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2304993, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/bugzilla refresh |
|
@GowthamShanmugam: This pull request references Bugzilla bug 2304993, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
We should not require any source map for prod builds we can always replicate the pages crashing by following the steps in our dev build. Usually we don't have access to production clusters of the customers so there is no point in trying to get access to the code that is causing errors in client clusters.
| devtool: 'eval-cheap-module-source-map', | ||
| // 'source-map' is recommended choice for production builds, A full SourceMap is emitted as a separate file. | ||
| // 'eval-source-map' is recommended for development but 'eval-cheap-module-source-map' is faster and gives better result. | ||
| devtool: isProduction ? 'source-map' : 'eval-cheap-module-source-map', |
There was a problem hiding this comment.
Let's put false for production.
| @@ -20,6 +20,7 @@ const NODE_ENV = (process.env.NODE_ENV || | |||
| 'development') as webpack.Configuration['mode']; | |||
| const PLUGIN = process.env.PLUGIN; | |||
| const OPENSHIFT_CI = process.env.OPENSHIFT_CI; | |||
| const isProduction = NODE_ENV === 'production'; | |||
There was a problem hiding this comment.
| const isProduction = NODE_ENV === 'production'; | |
| const IS_PRODUCTION = NODE_ENV === 'production'; |
I agree we don't have access, but the customer can paste the stack trace while creating a bug. We can't reproduce all the production issues, Without stack trace it will become hard to debug. source-map is made on a separate file, so it never affects the UI's initial loading time. |
|
/close |
|
@GowthamShanmugam: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 2304993. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #1520
/assign SanjalKatiyar