Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stylelint for CSS/SCSS linting and confirm ESLint for JS #1528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing TimothyAsirJeyasing commented Aug 9, 2024

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimothyAsirJeyasing
Once this PR has been reviewed and has the lgtm label, please assign cloudbehl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Aug 12, 2024

how did you test this PR ?

@TimothyAsirJeyasing
Copy link
Contributor Author

how did you test this PR ?

i test in the following order
yarn lint-css
yarn lint
yarn test
yarn build

@SanjalKatiyar
Copy link
Collaborator

i test in the following order yarn lint-css yarn lint yarn test yarn build

ask is to prevent addition of any class, variable, mixin, function names with a pf- prefix (only allowed prefixes should be pf-v5- and pf-m), did we test that on this PR ??

@TimothyAsirJeyasing
Copy link
Contributor Author

i test in the following order yarn lint-css yarn lint yarn test yarn build

ask is to prevent addition of any class, variable, mixin, function names with a pf- prefix (only allowed prefixes should be pf-v5- and pf-m), did we test that on this PR ??

// "selector-class-pattern": "^pf-(v5|m)-"
I have commented out class name checks as it fails for some names. I will change the names as per pf standards and will update this PR.

- Added Stylelint configuration to enforce styling rules in CSS/SCSS.

Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
@TimothyAsirJeyasing
Copy link
Contributor Author

The following is the change made for just to test the class name, var ...
image

yarn lint -> test results as follows:
image

@SanjalKatiyar
Copy link
Collaborator

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants