Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to nodejs 18.17.1 #1068

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Revert to nodejs 18.17.1 #1068

merged 1 commit into from
Oct 6, 2023

Conversation

GowthamShanmugam
Copy link
Contributor

@GowthamShanmugam GowthamShanmugam commented Oct 6, 2023 •
edited
Loading

Reason:
libuv update in 18.18.0 breaks webpack's thread-loader

Node issue:
nodejs/node#49911

Fix:
Reverting back the node version to 18.17.1 for a temporary fix.

The issue to revert back this temporary fix in the future:
#1069

@GowthamShanmugam GowthamShanmugam mentioned this pull request Oct 6, 2023
Open
@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2023
@GowthamShanmugam GowthamShanmugam changed the title libuv update in 18.18.0 breaks webpack's thread-loader Revert to nodejs 18.17.1 Oct 6, 2023
@GowthamShanmugam GowthamShanmugam mentioned this pull request Oct 6, 2023
Closed
@SanjalKatiyar
Copy link
Collaborator

/approve

@openshift-ci openshift-ci bot added the approved label Oct 6, 2023
@bipuladh
Copy link
Contributor

bipuladh commented Oct 6, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alfonsomthd, bipuladh, GowthamShanmugam, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SanjalKatiyar,bipuladh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 0ec1d7c into red-hat-storage:master Oct 6, 2023
6 checks passed
@GowthamShanmugam
Copy link
Contributor Author

/cherry-pick release-4.14

@GowthamShanmugam
Copy link
Contributor Author

/cherry-pick release-4.14-compatibility

@openshift-cherrypick-robot
Copy link

@GowthamShanmugam: new pull request created: #1076

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 10, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@GowthamShanmugam: new pull request created: #1077

In response to this:

/cherry-pick release-4.14-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@SanjalKatiyar SanjalKatiyar Awaiting requested review from SanjalKatiyar

Assignees

@alfonsomthd alfonsomthd

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GowthamShanmugam @SanjalKatiyar @bipuladh @openshift-cherrypick-robot @alfonsomthd