-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the cephblockpool reonciler to disable mirroring #2795
update the cephblockpool reonciler to disable mirroring #2795
Conversation
Signed-off-by: Rewant Soni <[email protected]>
Signed-off-by: Rewant Soni <[email protected]>
Signed-off-by: Rewant Soni <[email protected]>
Testing:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6cbff2c
into
red-hat-storage:main
/cherry-pick release-4.17 |
@rewantsoni: new pull request created: #2796 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When mirroring on storageCluster was disabled, the cephblockpool mirroring was not disabled, this could break the DR as MCO enables/disables the mirroring on the cephblockpool via storageCluster.
Hence, with this PR we are making the mirroring spec on the storageCluster as a pointer and enabling/disabling mirroring on cephblockpool only if the value is set. If mirroring is set to nil other controller will be able to make changes on the mirroring field on the cephblockpool.