Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider-api-server: updated client connection error message #2787

Closed
wants to merge 1 commit into from

Conversation

rohan47
Copy link
Contributor

@rohan47 rohan47 commented Sep 5, 2024

updated error message for storage client failed to connect. Now error message will show the IP of the provider server.

earlier it showed the following error message which was not clear
2024-07-10T07:37:41Z ERROR Reconciler error {"controller": "storageclient", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClient", "StorageClient": {"name":"storage-client"}, "namespace": "", "name": "storage-client", "reconcileID": "22f6a770-892d-4776-b04b-48af84b8ad4f", "error": "failed to create a new provider client: failed to dial: context deadline exceeded"}

updated error message for storage client failed to connect. Now error
message will show the IP of the provider server.

Signed-off-by: Rohan Gupta <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohan47
Once this PR has been reviewed and has the lgtm label, please assign jarrpa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2024
Copy link
Contributor

openshift-ci bot commented Sep 5, 2024

Hi @rohan47. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rohan47 rohan47 marked this pull request as draft September 5, 2024 16:36
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024
@leelavg
Copy link
Contributor

leelavg commented Sep 11, 2024

close if not required anymore?

@rohan47
Copy link
Contributor Author

rohan47 commented Sep 11, 2024

Not required anymore

@rohan47 rohan47 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants