Add watch verb to snapshot.storage.k8s.io group #2782
Conversation
| @@ -114,7 +114,7 @@ var validTopologyLabelKeys = []string{ | |||
| // +kubebuilder:rbac:groups=core,resources=namespaces,verbs=get | |||
| // +kubebuilder:rbac:groups=apps,resources=deployments;daemonsets;replicasets;statefulsets,verbs=get;list;watch;create;update;delete | |||
| // +kubebuilder:rbac:groups=monitoring.coreos.com,resources=servicemonitors;prometheusrules,verbs=get;list;watch;create;update;delete | |||
| // +kubebuilder:rbac:groups=snapshot.storage.k8s.io,resources=volumesnapshots;volumesnapshotclasses,verbs=get;create;delete | |||
| // +kubebuilder:rbac:groups=snapshot.storage.k8s.io,resources=volumesnapshots;volumesnapshotclasses,verbs=get;watch;create;delete | |||
There was a problem hiding this comment.
AFAIK ocs-operator doesnt need volumesnapshots permission that can be removed and also you need update access for volumesnapshotclass
There was a problem hiding this comment.
#2774 (comment)
@Madhu-1 I don't find the update verb in the code.
Removed volumesnapshots resource
There was a problem hiding this comment.
There was a problem hiding this comment.
@Madhu-1 @iamniting done
OdedViner
force-pushed
the
add_watch_snapshot
branch
from
c41316d
to
029c5b2
Compare
Discard, Missed Madhu's comment. |
OdedViner
force-pushed
the
add_watch_snapshot
branch
from
029c5b2
to
c4ef7f0
Compare
Signed-off-by: oviner <[email protected]>
OdedViner
force-pushed
the
add_watch_snapshot
branch
from
c4ef7f0
to
71c73fc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, OdedViner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 0f1459b
into
red-hat-storage:main
https://github.com/red-hat-storage/ocs-operator/blob/main/controllers/storagecluster/storagecluster_controller.go#L232