Available CRDs check feature (with script) #2741
Conversation
Reasons for this enhancement: - A controller cannot set up a watch for a CRD that is not installed on the cluster, trying to set up a watch will panic the operator - There is no known way, that we are aware of, to add a watch later without client cache issue How does the enhancement work around the issue: - On start up, detect which CRD are avail (out of a fixed list) and skip watches for ones that are not avail - At the start each reconcile iteration, revalidate which CRD are now available. If a CRD of interest is now avail, exit the op with a known exit code (42) - Have the pod command detect the exit code and if it is the known exist code (42), restart the process This process will guarantee that the pod does restart when a new CRD of interest becomes available. This in turn helps to avoid the following issue: - Pod will not get into CrushLoopBackoff state - There will be no change that the pod becomes unschedulable after restart as of missing resources Signed-off-by: raaizik <[email protected]> Co-Authored-By: Rewant Soni <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: raaizik The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@raaizik: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Changes
Reasons for this enhancement:
How does the enhancement work around the issue:
This process will guarantee that the pod does restart when a new CRD of
interest becomes available. This in turn helps to avoid the following
issue:
Note
#2712 is considered as a potential enhancement by @iamniting