Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds metadata to external ceph resources #2620

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Adds metadata to external ceph resources #2620

merged 1 commit into from
Sep 10, 2024

Conversation

raaizik
Copy link
Contributor

@raaizik raaizik commented May 20, 2024 •
edited
Loading

Changes

Adds metadata field to storage claim response proto message that contains a mirroring flag of CephBlockPool to be read directly from the StorageClaim's controller which will in turn label the StorageClass with the required Ramen labels that allow RBD mirroring.

Adds metadata in the form of labels and annotations to the ceph external resource struct.

RHSTOR-5754

@raaizik
Copy link
Contributor Author

raaizik commented May 20, 2024

/cc @nb-ohad

@openshift-ci openshift-ci bot requested a review from nb-ohad May 20, 2024 18:15
@raaizik raaizik changed the title Add mirroring flag to the block pool's data Adds mirroring flag to the block pool's data May 20, 2024
@raaizik
Copy link
Contributor Author

raaizik commented May 21, 2024

/retest

@raaizik raaizik force-pushed the RHSTOR-5754 branch 2 times, most recently from 92d4cf5 to 60764a0 Compare May 23, 2024 10:31
@raaizik
Copy link
Contributor Author

raaizik commented May 23, 2024

/cc @rewantsoni

@openshift-ci openshift-ci bot requested a review from rewantsoni May 23, 2024 11:37
rewantsoni
rewantsoni reviewed May 23, 2024
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
services/provider/server/server.go Outdated Show resolved Hide resolved
@raaizik raaizik force-pushed the RHSTOR-5754 branch 3 times, most recently from 62ee5f8 to 97ff9bd Compare May 23, 2024 14:14
@raaizik raaizik changed the title Adds mirroring flag to the block pool's data [WIP] Adds mirroring flag to the block pool's data May 27, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2024
@raaizik raaizik changed the title [WIP] Adds mirroring flag to the block pool's data [WIP] Adds metadata to ceph resources May 28, 2024
@raaizik raaizik force-pushed the RHSTOR-5754 branch 7 times, most recently from 4652707 to a052245 Compare May 30, 2024 16:02
@raaizik raaizik changed the title [WIP] Adds metadata to ceph resources [WIP] Adds metadata to storage storage claim response proto message May 30, 2024
@raaizik raaizik changed the title [WIP] Adds metadata to storage storage claim response proto message [WIP] Adds metadata to storage claim response proto message May 30, 2024
@raaizik
Copy link
Contributor Author

raaizik commented Jun 3, 2024

/retest

@raaizik
Copy link
Contributor Author

raaizik commented Aug 26, 2024

/retest-required

@raaizik
Copy link
Contributor Author

raaizik commented Aug 26, 2024

/test ocs-operator-bundle-e2e-aws

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
nb-ohad
nb-ohad requested changes Sep 8, 2024
View reviewed changes
services/provider/server/server.go Outdated Show resolved Hide resolved
@rewantsoni rewantsoni mentioned this pull request Sep 8, 2024
Open
@raaizik raaizik changed the title Adds metadata to storage claim response proto message Adds metadata to external ceph resources Sep 9, 2024
@raaizik raaizik force-pushed the RHSTOR-5754 branch 3 times, most recently from 7e680cc to 86cd280 Compare September 9, 2024 12:42
@raaizik raaizik requested a review from nb-ohad September 9, 2024 12:42
@raaizik raaizik force-pushed the RHSTOR-5754 branch 2 times, most recently from f1bccf0 to 5918436 Compare September 9, 2024 13:34
@rewantsoni
Copy link
Member

LGTM

nb-ohad
nb-ohad requested changes Sep 9, 2024
View reviewed changes
services/provider/proto/provider.proto Outdated Show resolved Hide resolved
@raaizik raaizik requested a review from nb-ohad September 9, 2024 15:45
@nb-ohad
Copy link
Contributor

nb-ohad commented Sep 10, 2024

LGTM,
@leelavg, as our protobuf expert, can you please also take a look?

@leelavg
Copy link
Contributor

leelavg commented Sep 10, 2024

LGTM,
@leelavg, as our protobuf expert, can you please also take a look?

  • not by a long shot, change lgtm.

Sooner than later we might want to move proto definitions and client svc into it's own go module as I see huge deps ending up in client-op in each update, wdyt @nb-ohad?

@nb-ohad
Copy link
Contributor

nb-ohad commented Sep 10, 2024

Sooner than later we might want to move proto definitions and client svc into it's own go module as I see huge deps ending up in client-op in each update, wdyt @nb-ohad?

That might or might not be a future target. But that does not directly relate to this change. So can we merge?

@leelavg
Copy link
Contributor

leelavg commented Sep 10, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@nb-ohad
Copy link
Contributor

nb-ohad commented Sep 10, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad, raaizik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b82b171 into red-hat-storage:main Sep 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leelavg leelavg leelavg left review comments

@rewantsoni rewantsoni Awaiting requested review from rewantsoni

@nb-ohad nb-ohad Awaiting requested review from nb-ohad

Assignees

@nb-ohad nb-ohad

@leelavg leelavg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@raaizik @rewantsoni @Nikhil-Ladha @nb-ohad @leelavg @openshift-merge-robot