Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of volume migration tool #2598

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jarrpa
Copy link
Member

@jarrpa jarrpa commented May 7, 2024

This PR contains an initial set of commits for a volume migration tool for OCS.

At the moment the tool is not guaranteed to work, and thus I'm not looking for a review of the code itself. The main purpose of this PR is to verify that committing it to the repo doesn't break the CI or development environment of other contributors. It is also intended to get the tool integrated into downstream CD/CI pipelines.

Signed-off-by: Jose A. Rivera [email protected]

Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@jarrpa jarrpa force-pushed the jarrpa/vol-mv-dump branch 19 times, most recently from 9ec3ec6 to 783e2dc Compare May 8, 2024 06:36
@jarrpa
Copy link
Member Author

jarrpa commented May 8, 2024

/retest

@jarrpa jarrpa force-pushed the jarrpa/vol-mv-dump branch 6 times, most recently from 92acd85 to 84f8bb1 Compare May 8, 2024 16:17
@jarrpa jarrpa changed the title Jarrpa/vol mv dump Initial commit of volume migration tool May 9, 2024
@jarrpa jarrpa force-pushed the jarrpa/vol-mv-dump branch 2 times, most recently from d31f76a to f393603 Compare May 10, 2024 12:15
@jarrpa
Copy link
Member Author

jarrpa commented May 10, 2024

/retest

@jarrpa
Copy link
Member Author

jarrpa commented May 15, 2024

/retest

1 similar comment
@jarrpa
Copy link
Member Author

jarrpa commented May 16, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
Previously, the paths given to controller-gen have it scanning all go
packages in the repo for relevant kubebuilder markers. This can cause
problems with parts of the repo that may need additional libraries
installed in the runtime environment but are not required for the
operator or its bundle manifests.

Limiting controller-gen to only scan the directories that are actually
relevant to its functionality resolves this, and just seems like a good
idea in general.

Signed-off-by: Jose A. Rivera <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2024
At the moment, this tool is not guaranteed to work as intended across
all environments. This commit is to help start integrating the tool into
our CI/CD pipelines, and also to verify that it doesn't break anything
for the rest of the repo.

Signed-off-by: Jose A. Rivera <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants