Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: fix broken build for ARM64-arch #1904

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hack: fix broken build for ARM64-arch #1904

wants to merge 1 commit into from

Conversation

synarete
Copy link
Contributor

@synarete synarete commented Dec 25, 2022 •
edited by openshift-ci bot
Loading

When building over AWS-Graviton, need to use ARM64 (aarch64) protoc binaries. Upstream project does not provides proper ARM64 binaries for protoc-gen-go and protoc-gen-go-grpc so we need to build it from source within temporary directory.

Refs RHSTOR-2044

Signed-off-by: Shachar Sharon [email protected]

@synarete
Copy link
Contributor Author

synarete commented Dec 25, 2022 via email

@synarete synarete mentioned this pull request Dec 26, 2022
Open
iamniting
iamniting reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, Were these changes tested well? CI does not test it on arm ENV so we need to make sure they work well.

iamniting
iamniting reviewed Jan 9, 2023
View reviewed changes
hack/common.sh
@@ -5,9 +5,9 @@

GO111MODULE="on"
GOPROXY="https://proxy.golang.org"
GOROOT="${GOROOT:-go env GOROOT}"
GOROOT="${GOROOT:-$(go env GOROOT)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the failure in the CI it looks like we don't have go in the openshift CI. We also need to figure this out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a chicken-and-egg problem: you first need to be able to build ocs-operator over ARM64 before you may test it via CI.

@synarete
Copy link
Contributor Author

synarete commented Jan 9, 2023

The changes look good to me, Were these changes tested well? CI does not test it on arm ENV so we need to make sure they work well.

Currently, I am testing the build process over ARM64 using RH's beaker machines. This is just the first step in a more comprehensive cycle of adjusting ocs-operator to ARM64 environment (specifically, AWS Graviton). See #1906 for more details.

@iamniting iamniting added the 4.13-feature Indicates the PR's required to go to main before feature freeze of release 4.13 label Feb 8, 2023
@synarete
hack: fix broken build for ARM64-arch
7983897 
When building over AWS-Graviton, need to use ARM64 (aarch64) protoc
binaries. Upstream project does not provides proper ARM64 binaries for
protoc-gen-go and protoc-gen-go-grpc so we need to build it from source
within temporary directory.

Refs RHSTOR-2044

Signed-off-by: Shachar Sharon <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: synarete
Once this PR has been reviewed and has the lgtm label, please assign agarwal-mudit for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@synarete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 7983897 link true /test images
ci/prow/ocs-operator-bundle-e2e-aws 7983897 link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
4.13-feature Indicates the PR's required to go to main before feature freeze of release 4.13 needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@synarete @openshift-merge-robot @iamniting