Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates (Go 1.17, K8s 1.23.4, controller-runtime 0.11.1, sdk 1.17.0) #1578

Merged

Conversation

umangachapagain
Copy link
Contributor

@umangachapagain umangachapagain commented Mar 8, 2022

Updates to:
Go 1.17 (Including CI)
K8s 1.23.4
controller-runtime 0.11.1
operator-sdk 1.17.0 (and PROJECT config to v3 stable)
controller-gen 0.8.0
kustomize 4.5.2

Fixes: #1426 #1407

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 8, 2022
@umangachapagain umangachapagain added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2022
@umangachapagain umangachapagain force-pushed the deps-updates branch 2 times, most recently from 435e465 to e71a410 Compare March 14, 2022 09:06
@umangachapagain umangachapagain changed the title [WIP] Dependency updates (Go 1.17, K8s 1.23.4, controller-runtime 0.11.1, sdk 1.18) [WIP] Dependency updates (Go 1.17, K8s 1.23.4, controller-runtime 0.11.1, sdk 1.17.0) Mar 14, 2022
@umangachapagain umangachapagain changed the title [WIP] Dependency updates (Go 1.17, K8s 1.23.4, controller-runtime 0.11.1, sdk 1.17.0) Dependency updates (Go 1.17, K8s 1.23.4, controller-runtime 0.11.1, sdk 1.17.0) Mar 14, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2022
@umangachapagain umangachapagain removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2022
@umangachapagain umangachapagain force-pushed the deps-updates branch 4 times, most recently from fd92a3e to ae7a6ad Compare March 16, 2022 07:06
Signed-off-by: Umanga Chapagain <[email protected]>
Update to kubernetes v1.23.4
Update to controller-runtime v0.11.1
Update operatorframework dependencies

Lock kube-openapi dependency as newer versions breaks NooBaa.
Replace deprecated operatorframework api function.
Fix TestEnsureNooBaaSystem test.

Signed-off-by: Umanga Chapagain <[email protected]>
Update controller-gen to v0.8.0 and kusomize to v4.5.2 and
fix make targets to install these tools only if required
version is not available.

Update operator-sdk to v1.17.0.

Signed-off-by: Umanga Chapagain <[email protected]>
Config version 3-alpha has been stabilized as 3, and 3-alpha is no longer supported.
This commit converts PROJECT config file from version 3-alpha to 3.

Signed-off-by: Umanga Chapagain <[email protected]>
Signed-off-by: Umanga Chapagain <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

@umangachapagain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 6a93d27 link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@agarwal-mudit
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agarwal-mudit,umangachapagain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a2a20b8 into red-hat-storage:main Mar 16, 2022
@umangachapagain umangachapagain deleted the deps-updates branch March 16, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update of OLM dependency blocked
3 participants