-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move crd api into a separate go module #233
Conversation
/hold can only review first commit, compilation is working, doing a test for runtime type registration atm. |
/unhold tested
|
/hold for two reviews. |
/unhold |
/rebase |
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
rebased. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
38cad9a
into
red-hat-storage:main
this helps for code that is depending on client-op CRDs to only pull the submodule rather than whole client-op and also remove controller-runtime from this new submodule.