Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move crd api into a separate go module #233

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Sep 17, 2024

this helps for code that is depending on client-op CRDs to only pull the submodule rather than whole client-op and also remove controller-runtime from this new submodule.

@leelavg
Copy link
Contributor Author

leelavg commented Sep 17, 2024

/hold

can only review first commit, compilation is working, doing a test for runtime type registration atm.

@leelavg
Copy link
Contributor Author

leelavg commented Sep 17, 2024

/unhold

tested make run

2024-09-17T05:29:00Z    INFO    Starting Controller     {"controller": "configmap", "controllerGroup": "", "controllerKind": "ConfigMap"}
2024-09-17T05:29:01Z    INFO    Starting workers        {"controller": "storageclaim", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClaim", "worker count": 1}
2024-09-17T05:29:01Z    INFO    Starting workers        {"controller": "storageclient", "controllerGroup": "ocs.openshift.io", "controllerKind": "StorageClient", "worker count": 1}
2024-09-17T05:29:01Z    INFO    Starting workers        {"controller": "configmap", "controllerGroup": "", "controllerKind": "ConfigMap", "worker count": 1}

Makefile Show resolved Hide resolved
go.mod Show resolved Hide resolved
api/go.mod Outdated Show resolved Hide resolved
api/v1alpha1/groupversion_info.go Outdated Show resolved Hide resolved
api/go.mod Outdated Show resolved Hide resolved
@leelavg
Copy link
Contributor Author

leelavg commented Sep 17, 2024

/hold

for two reviews.

@leelavg
Copy link
Contributor Author

leelavg commented Oct 1, 2024

/unhold

@leelavg leelavg changed the title move api into a separate go module move crd api into a separate go module Oct 1, 2024
@leelavg
Copy link
Contributor Author

leelavg commented Oct 1, 2024

/rebase

@leelavg
Copy link
Contributor Author

leelavg commented Oct 1, 2024

rebased.

@nb-ohad
Copy link
Contributor

nb-ohad commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
Copy link

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 38cad9a into red-hat-storage:main Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants