Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get also kubectl binary when extracting oc from image #10823

Merged
merged 1 commit into from
Nov 7, 2024
Merged

get also kubectl binary when extracting oc from image #10823

merged 1 commit into from
Nov 7, 2024

Conversation

dahorak
Copy link
Contributor

@dahorak dahorak commented Nov 7, 2024

  • kubectl binary is used by some 3rd party scripts (e.g. ACM deployment script)
  • in case that downloading of openshift-client from openshift-release-artifacts doesn't work and oc binary is extracted from an image, we have to specifically extract also the kubectl binary

@dahorak dahorak added the team/ecosystem Ecosystem team related issues/PRs label Nov 7, 2024
@dahorak dahorak self-assigned this Nov 7, 2024
@dahorak dahorak requested a review from a team as a code owner November 7, 2024 12:57
@dahorak dahorak marked this pull request as draft November 7, 2024 13:57
@dahorak dahorak force-pushed the extract-also-kubectl-when-extracting-oc-from-image branch from 3662bdc to fa11837 Compare November 7, 2024 14:12
@dahorak
create also kubectl link to oc binary when extracting oc from image
cf40bb8 
- kubectl binary is used by some 3rd party scripts (e.g. ACM deployment
  script)

Signed-off-by: Daniel Horak <[email protected]>
@dahorak dahorak force-pushed the extract-also-kubectl-when-extracting-oc-from-image branch from fa11837 to cf40bb8 Compare November 7, 2024 14:14
@dahorak dahorak marked this pull request as ready for review November 7, 2024 14:17
@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

Verified locally:

15:16:26 - MainThread - ocs_ci.utility.utils - INFO  - Executing command: /tmp/oc adm release extract -a data/pull-secret --command=<image> --to .
15:16:40 - MainThread - ocs_ci.utility.utils - INFO  - Executing command: ocs-ci/bin/oc version --client
15:16:40 - MainThread - ocs_ci.utility.utils - INFO  - Creating kubectl link to oc binary.

@dahorak dahorak added the Verified Mark when PR was verified and log provided label Nov 7, 2024
@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
shylesh
shylesh approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-balogh petr-balogh merged commit 4fa79a7 into red-hat-storage:master Nov 7, 2024
6 of 7 checks passed
@petr-balogh
Copy link
Member

@dahorak please cherry-picks for all versions till 4.12 where we do use this extract oc from release image

@dahorak dahorak deleted the extract-also-kubectl-when-extracting-oc-from-image branch November 7, 2024 15:18
@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

/cherry-pick release-4.16

@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

/cherry-pick release-4.15

@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

/cherry-pick release-4.14

@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

/cherry-pick release-4.13

@dahorak
Copy link
Contributor Author

dahorak commented Nov 7, 2024

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link
Collaborator

@dahorak: new pull request created: #10824

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@dahorak: new pull request created: #10825

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2024
Merged
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2024
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@dahorak: new pull request created: #10826

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Nov 7, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@dahorak: new pull request created: #10827

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@dahorak: new pull request created: #10828

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-balogh petr-balogh petr-balogh approved these changes

@shylesh shylesh shylesh approved these changes

Assignees

@shylesh shylesh

@dahorak dahorak

@petr-balogh petr-balogh

Labels
lgtm size/XS team/ecosystem Ecosystem team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dahorak @petr-balogh @openshift-cherrypick-robot @shylesh