Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<GSS Closed Loop BZ:2253013>: Test to create SC & CBP from UI and validate pg_num #10657

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Shrivaibavi
Copy link
Contributor

@Shrivaibavi Shrivaibavi requested a review from a team as a code owner October 11, 2024 18:28
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Oct 11, 2024
Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shrivaibavi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shrivaibavi Shrivaibavi added team/e2e E2E team related issues/PRs Customer defects Defects automated aspart of GSS closed loop Squad/Black Covers UI specific test cases such as ODF Dashboard etc. labels Oct 11, 2024
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: sraghave-oct11
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/ui/test_create_sc_and_pool_ui.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master

Job PASSED.

@Shrivaibavi Shrivaibavi added the Verified Mark when PR was verified and log provided label Oct 11, 2024
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines and removed size/M PR that changes 30-99 lines labels Oct 14, 2024

"""

def test_sc_and_pool_ui_and_validate_pg_num(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have an existing UI test that covers the most of these steps in this test. Should we just add the pg_num validation to that existing test instead of creating a new one?

https://github.com/red-hat-storage/ocs-ci/blob/4bbd16255e426318b3f9530b79510d6c5c3e0fd6/tests/cross_functional/ui/test_create_pool_block_pool.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it as a new test, I dint want to add steps to the existing test as the fix is available from 4.16 whereas the previous test can run from 4.8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.8 is quite a while back and versions shouldn't be a problem since we have stable branches created. I still feel we should simply add the pg_num validation to the existing test rather than creating a new test case, as I don't see the need for it. This is my opinion, but please also get input from the Black squad as it is a UI test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @PrasadDesala
UI tests are time consuming. The simplest test lasts about 3 min.

…om UI and check the pg_num

Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
@pull-request-size pull-request-size bot added size/M PR that changes 30-99 lines and removed size/L PR that changes 100-499 lines labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer defects Defects automated aspart of GSS closed loop size/M PR that changes 30-99 lines Squad/Black Covers UI specific test cases such as ODF Dashboard etc. team/e2e E2E team related issues/PRs Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants