-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<GSS Closed Loop BZ:2253013>: Test to create SC & CBP from UI and validate pg_num #10657
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shrivaibavi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR validation on existing cluster
Cluster Name: sraghave-oct11
Cluster Configuration:
PR Test Suite: tier1
PR Test Path: tests/functional/ui/test_create_sc_and_pool_ui.py
Additional Test Params:
OCP VERSION: 4.17
OCS VERSION: 4.17
tested against branch: master
3be9025
to
357e962
Compare
|
||
""" | ||
|
||
def test_sc_and_pool_ui_and_validate_pg_num( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have an existing UI test that covers the most of these steps in this test. Should we just add the pg_num validation to that existing test instead of creating a new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it as a new test, I dint want to add steps to the existing test as the fix is available from 4.16 whereas the previous test can run from 4.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.8 is quite a while back and versions shouldn't be a problem since we have stable branches created. I still feel we should simply add the pg_num validation to the existing test rather than creating a new test case, as I don't see the need for it. This is my opinion, but please also get input from the Black squad as it is a UI test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @PrasadDesala
UI tests are time consuming. The simplest test lasts about 3 min.
…om UI and check the pg_num Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
Signed-off-by: Shrivaibavi Raghaventhiran <[email protected]>
357e962
to
322479f
Compare
bug : https://bugzilla.redhat.com/show_bug.cgi?id=2253013