Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16 backport] Use the secure external endpoint and the needed CA for RGW SSL external deployments #10527

Merged
merged 2 commits into from
Oct 17, 2024
Merged

[release-4.16 backport] Use the secure external endpoint and the needed CA for RGW SSL external deployments #10527

merged 2 commits into from
Oct 17, 2024

Conversation

sagihirshfeld
Copy link
Contributor

release-4.16 backport of #10426, which also applies the fix from #10426

@sagihirshfeld
Use the secure external endpoint and the needed CA for RGW SSL extern…
fef91e5 
…al deployments (red-hat-storage#10426)

* Use the config file variables and add the missing CA to the awscli pod
* Change the CA handling on the awscli pod

Signed-off-by: Sagi Hirshfeld <[email protected]>
@sagihirshfeld
Fix external mode rgw_secure condition
0b79bbf 
Signed-off-by: Sagi Hirshfeld <[email protected]>
@sagihirshfeld sagihirshfeld added RGW Issues related to the Ceph Object Gateway Squad/Red labels Sep 18, 2024
@sagihirshfeld sagihirshfeld self-assigned this Sep 18, 2024
@sagihirshfeld sagihirshfeld requested a review from a team as a code owner September 18, 2024 15:59
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 18, 2024

@sagihirshfeld: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.16 backport] Use the secure external endpoint and the needed CA for RGW SSL external deployments

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines label Sep 18, 2024
@sagihirshfeld sagihirshfeld mentioned this pull request Sep 18, 2024
Merged
@sagihirshfeld sagihirshfeld added the cherry-pick This is cherry-pick (backport) label Sep 18, 2024
@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DanielOsypenko, keesturam, OdedViner, sagihirshfeld

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@keesturam keesturam merged commit ae52add into red-hat-storage:release-4.16 Oct 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OdedViner OdedViner OdedViner approved these changes

@DanielOsypenko DanielOsypenko DanielOsypenko approved these changes

@keesturam keesturam keesturam approved these changes

@dahorak dahorak Awaiting requested review from dahorak

@petr-balogh petr-balogh Awaiting requested review from petr-balogh

Assignees

@keesturam keesturam

@sagihirshfeld sagihirshfeld

@DanielOsypenko DanielOsypenko

@OdedViner OdedViner

Labels
cherry-pick This is cherry-pick (backport) lgtm RGW Issues related to the Ceph Object Gateway size/S PR that changes 10-29 lines Squad/Red
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sagihirshfeld @keesturam @DanielOsypenko @OdedViner