Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10479: Add the missing threading_lock object in test_ceph_health #10480

Open
wants to merge 3 commits into
base: release-4.14
Choose a base branch
from

Conversation

PrasadDesala
Copy link
Contributor

Fixes: #10479

@PrasadDesala PrasadDesala self-assigned this Sep 13, 2024
@PrasadDesala PrasadDesala requested a review from a team as a code owner September 13, 2024 07:52
Copy link

openshift-ci bot commented Sep 13, 2024

@PrasadDesala: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fixes #10479: Add the missing threading_lock object in test_ceph_health

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PrasadDesala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Prasad Desala <[email protected]>
Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation on existing cluster

Cluster Name: tdesala-sep10
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/monitoring/prometheus/test_ceph.py::test_ceph_health
Additional Test Params:
OCP VERSION: 4.14-ga
OCS VERSION: 4.14
tested against branch: release-4.14

Job PASSED.

Copy link

@ocs-ci ocs-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR validation

Cluster Name:
Cluster Configuration:
PR Test Suite: tier4a
PR Test Path: tests/manage/monitoring/prometheus/test_ceph.py::test_ceph_health
Additional Test Params:
OCP VERSION: 4.14-ga
OCS VERSION: 4.14
tested against branch: release-4.14

Job UNSTABLE (some or all tests failed).

@PrasadDesala
Copy link
Contributor Author

PrometheusAPI class init passed without any NoThreadingLockUsedError exception. Adding verified label.

@PrasadDesala PrasadDesala added the Verified Mark when PR was verified and log provided label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Squad/Blue Verified Mark when PR was verified and log provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants