Review Dockerfile and RPM files for building odh-modelmesh-serving-controller in onflux #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller in konflux
…ntroller in onflux
…ntroller in onflux
|
Hi, it is still a draft, is this PR ready for review? |
…ntroller in onflux
Hello, Please review the PR |
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
spolti
reviewed
Oct 15, 2024
|
|
||
|
|
||
| ## Install additional packages | ||
| RUN microdnf install -y shadow-utils &&\ |
There was a problem hiding this comment.
why are you adding this if no user is being added?
There was a problem hiding this comment.
I have not added it, referred from the midstream dockerfile
There was a problem hiding this comment.
we are not adding users, it can be removed..
spolti
reviewed
Oct 15, 2024
| - url: https://cdn-ubi.redhat.com/content/public/ubi/dist/ubi8/8/x86_64/baseos/os/Packages/s/shadow-utils-4.6-22.el8.x86_64.rpm | ||
| repoid: ubi-8-baseos-rpms | ||
| size: 1292332 | ||
| checksum: sha256:ea73ee201451bbca0d6d14ca434c93800f01c8fb1b9daef727a5af1a27356d07 |
spolti
reviewed
Oct 15, 2024
…ntroller in onflux
spolti
reviewed
Oct 16, 2024
| ############################################################################### | ||
| # Stage 2: Copy build assets to create the smallest final runtime image | ||
| ############################################################################### | ||
| #ubi-minimal:latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #https://issues.redhat.com/browse/RHOAIENG-14146