Conversation
| $cfg = ($cfg | merge deep { | ||
| subnet: { | ||
| addresses: { | ||
| credit_manager: $env.state.creditManager_contract_address |
There was a problem hiding this comment.
@sam701 we no longer need to deploy the wrapper / "manager" contracts. i just merged ad096f2 in the contracts repo, which removes them entirely.
i created issues in https://github.com/recallnet/recall-docker-compose/issues/60 and https://github.com/recallnet/recall-deploy/issues/308 to account for this elsewhere. (i should have gave you a heads up wrt the IaC...sorry about that.)
There was a problem hiding this comment.
or, i suppose we could keep your existing logic in this PR. then, create a follow up PR that updates ipc's recall-contracts submodule to ad096f2, and align that with the two issues mentioned in the comment above.
if that makes sense to you, i created this ticket as a follow up: #621
There was a problem hiding this comment.
@dtbuchholz cool, thank you! The scripts in recall-deploy will be removed once this PR is merged. I'll move your issue from recall-deploy to this repo.
dtbuchholz
left a comment
There was a problem hiding this comment.
@sam701 works great. two small pieces of feedback:
- it'd be nice to have a "stop" script, too, just to make it easy to shut down the network. not a blocker tho.
- i noticed this creates a
localnet-data/dir root—should we.gitignorethis?
per your README, is it correct in stating: the only dependency a user needs is nu? for docs site purposes, i'm just double checking there's no longer a need for all of these build deps (which is a great DX improvement).
It's already there:
Yes in
That is correct, there is no need for any additional tools (only docker). All the tools (cast, ipc-cli, etc.), that are actually required by the setup process, are called from docker containers. |
duh, totally missed that. perfect.
ah so i tried running it from root like |
|
@sam701 but, i just came across a weird issue. after stopping the localnet manually with docker, i tried running i then try to rebuild the image manually via the |
It's a good point! It is built to be retryable because any step can fail, especially on testnet. That means when you run
This has the same nature as above because |
Move state-path to util
This PR contains scripts (a copy from
recall-deploy) to deploy localnet on local docker and to create a single docker image with the entire localnet inside.This is intended to replace
deploy.sh, ref: #603