RCORE-2225 Loosen the FLX download progress test assertions to work with QBSv2 #7953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/download-completion-on-client-reset
branch
from
329c1c6
to
7e20b9f
Compare
tgoyne
force-pushed
the
tg/qbsv2-progress-test
branch
from
92148fa
to
6605c9e
Compare
Pull Request Test Coverage Report for Build thomas.goyne_493Details
💛 - Coveralls |
michael-wb
reviewed
Aug 5, 2024
Comment on lines
-1346
to
+1333
| double expected_step = (1.0 - entries.front()) / (size - 1); | ||
| for (size_t i = 1; i < size; ++i) { | ||
| double expected_step = 1.0 / size; | ||
| for (size_t i = 0; i < size; ++i) { |
There was a problem hiding this comment.
Can we always assume that the first entry in the list is 0?
What if the progress notification was registered while the transfer has already been started and the first one or more progress items were missed?
(I am thinking of one of my planned test cases for the client reset progress notifications, where the download callback is registered while the fresh realm download is already in progress).
There was a problem hiding this comment.
The current tests all register the notification before doing anything which would produce notifications. Tests in the future which do something different will need different checks.
tgoyne
force-pushed
the
tg/download-completion-on-client-reset
branch
3 times, most recently
from
c78df18
to
edc1174
Compare
tgoyne
force-pushed
the
tg/download-completion-on-client-reset
branch
from
edc1174
to
0857d0e
Compare
With QBSv2 the progress reported when a client reconnects after offline writes is progress through a history scan rather than download progress, so we can't make as strong of assertions about what the expected values are.
tgoyne
force-pushed
the
tg/qbsv2-progress-test
branch
from
6605c9e
to
6f1cde2
Compare
tgoyne
force-pushed
the
tg/download-completion-on-client-reset
branch
from
0857d0e
to
80604f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With QBSv2 the progress reported when a client reconnects after offline writes is progress through a history scan rather than download progress, so we can't make as strong of assertions about what the expected values are.