Honor allow_zero_lintable_files set in a parent configuration - #6761
Closed
systemblueio wants to merge 1 commit into
Closed
systemblueio wants to merge 1 commit into
systemblueio wants to merge 1 commit into
Conversation
Merging always took the child's allowZeroLintableFiles value, which defaults to false, so a parent config that set it to true was reset whenever a child config omitted the key. OR the parent and child values instead, and add a merge regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Generated by 🚫 Danger |
SimplyDanny
reviewed
Jun 8, 2026
| cachePath: cachePath, | ||
| allowZeroLintableFiles: childConfiguration.allowZeroLintableFiles, | ||
| allowZeroLintableFiles: allowZeroLintableFiles || childConfiguration.allowZeroLintableFiles, | ||
| strict: childConfiguration.strict, |
Collaborator
There was a problem hiding this comment.
The same can be discussed about the other properties, too. reporter and cachePath don't even see, to support overwriting. So I'm not very happy to just change the behavior for allowZeroLintableFiles if we don't have a good general concept.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6240.
Merging always took the child config's
allowZeroLintableFiles, which defaults tofalse, soallow_zero_lintable_files: truein aparent_configwas reset whenever the child omitted the key. This ORs the parent and child values and adds a merge regression test.Verified with
swift test --filter MultipleConfigurationsTests(30 tests pass).