Skip to content

fix(modifier_order): recognize isolated isolation modifier - #6649

Closed
wyf027 wants to merge 2 commits into
realm:mainfrom
wyf027:fix/modifier-order-isolated-keyword-6164
Closed

wyf027 wants to merge 2 commits into
realm:mainfrom
wyf027:fix/modifier-order-isolated-keyword-6164

Conversation

@wyf027

@wyf027 wyf027 commented May 17, 2026 •

Copy link
Copy Markdown

Summary

  • Map the isolated declaration modifier to the existing isolation modifier group in modifier_order.
  • Users can now order isolated via isolation in preferred_modifier_order, consistent with nonisolated.

Fixes #6164

Test plan

  • Extended testIsolationModifierOrder with isolated non-triggering/triggering/correction examples
  • CI (Buildkite)

@SwiftLintBot

Copy link
Copy Markdown
19 Messages
📖 Building this branch resulted in the same binary size as when built on main.
📖 Linting Aerial with this PR took 0.8 s vs 0.83 s on main (3% faster).
📖 Linting Alamofire with this PR took 1.12 s vs 1.09 s on main (2% slower).
📖 Linting Brave with this PR took 7.43 s vs 7.39 s on main (0% slower).
📖 Linting DuckDuckGo with this PR took 29.91 s vs 29.92 s on main (0% faster).
📖 Linting Firefox with this PR took 12.7 s vs 12.65 s on main (0% slower).
📖 Linting Kickstarter with this PR took 8.64 s vs 8.64 s on main (0% slower).
📖 Linting Moya with this PR took 0.46 s vs 0.48 s on main (4% faster).
📖 Linting NetNewsWire with this PR took 2.92 s vs 2.89 s on main (1% slower).
📖 Linting Nimble with this PR took 0.69 s vs 0.69 s on main (0% slower).
📖 Linting PocketCasts with this PR took 8.21 s vs 8.26 s on main (0% faster).
📖 Linting Quick with this PR took 0.47 s vs 0.46 s on main (2% slower).
📖 Linting Realm with this PR took 3.0 s vs 3.02 s on main (0% faster).
📖 Linting Sourcery with this PR took 1.91 s vs 1.91 s on main (0% slower).
📖 Linting Swift with this PR took 4.82 s vs 4.86 s on main (0% faster).
📖 Linting SwiftLintPerformanceTests with this PR took 0.3 s vs 0.35 s on main (14% faster).
📖 Linting VLC with this PR took 1.27 s vs 1.27 s on main (0% slower).
📖 Linting Wire with this PR took 19.32 s vs 19.27 s on main (0% slower).
📖 Linting WordPress with this PR took 13.07 s vs 13.05 s on main (0% slower).

Generated by 🚫 Danger

@SimplyDanny
SimplyDanny enabled auto-merge (squash) May 19, 2026 08:25
Map the `isolated` keyword to the `isolation` modifier group so it participates
in `preferred_modifier_order` sorting alongside `nonisolated`.

Fixes #6164
auto-merge was automatically disabled May 31, 2026 17:03

Head branch was pushed to by a user without write access

@SimplyDanny
SimplyDanny enabled auto-merge (squash) May 31, 2026 17:48
auto-merge was automatically disabled May 31, 2026 18:15

Head branch was pushed to by a user without write access

@SimplyDanny

Copy link
Copy Markdown
Collaborator

Superseded by #6759.

@SimplyDanny SimplyDanny closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

isolation parameter for modifier_order rule

3 participants