Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implements FunctionArgumentsSpacingRule #5337

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

implements FunctionArgumentsSpacingRule #5337

wants to merge 28 commits into from
+170 −2

Commits on Feb 11, 2024

  1. wip

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4e0e137 View commit details
    Browse the repository at this point in the history

  2. implement rule

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    9cb3de3 View commit details
    Browse the repository at this point in the history

  3. add: description and lil refactoring

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    a4f2e81 View commit details
    Browse the repository at this point in the history

  4. change: confirm Rule

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c39187c View commit details
    Browse the repository at this point in the history

  5. add: FunctionArgumentsSpacingRuleGeneratedTests

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    98ae8b7 View commit details
    Browse the repository at this point in the history

  6. change: move test examples into rule description

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    281e73d View commit details
    Browse the repository at this point in the history

  7. change: consider for function with no parameters

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f1e35a7 View commit details
    Browse the repository at this point in the history

  8. restore the newline

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    485c606 View commit details
    Browse the repository at this point in the history

  9. add: triggering the rule with multiple spaces

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c744b9d View commit details
    Browse the repository at this point in the history

  10. fix: linter is triggered when a comment is included

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8c9e54b View commit details
    Browse the repository at this point in the history

  11. update: checks the trivia at each of the variables and at the paren a… 

    …nd add comment
    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5715490 View commit details
    Browse the repository at this point in the history

  12. add: CHANGELOG

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f88686d View commit details
    Browse the repository at this point in the history

  13. fix: change trailingTrivia to leadingTrivia

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    ff605ad View commit details
    Browse the repository at this point in the history

  14. handle newline

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5d5c868 View commit details
    Browse the repository at this point in the history

  15. fix: pass all tests

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    6493850 View commit details
    Browse the repository at this point in the history

  16. rerun

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c2e50d1 View commit details
    Browse the repository at this point in the history

  17. Update Source/SwiftLintBuiltInRules/Rules/Lint/FunctionArgumentsSpaci… 

    …ngRule.swift

Co-authored-by: Danny Mösch <[email protected]>
    @u-abyss @SimplyDanny
    u-abyss and SimplyDanny committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c319bd2 View commit details
    Browse the repository at this point in the history

  18. change: function name

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    32bbf0d View commit details
    Browse the repository at this point in the history

  19. update: passed all current tests

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    99c421b View commit details
    Browse the repository at this point in the history

  20. update: trigger comment and tab

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    bb4267d View commit details
    Browse the repository at this point in the history

  21. change: logic

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    df301a7 View commit details
    Browse the repository at this point in the history

  22. wip

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e355ba6 View commit details
    Browse the repository at this point in the history

  23. update: not triggering when argument with linecomment

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e68a3c6 View commit details
    Browse the repository at this point in the history

  24. wip

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4035a88 View commit details
    Browse the repository at this point in the history

  25. refactoring

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    89f32ae View commit details
    Browse the repository at this point in the history

  26. add: test case

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8594397 View commit details
    Browse the repository at this point in the history

  27. refactoring

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2f86326 View commit details
    Browse the repository at this point in the history

  28. change: name and description

    @u-abyss
    u-abyss committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    dfbec83 View commit details
    Browse the repository at this point in the history