Skip to content

feat(cli): add --url alias for --source in note-wiki command - #3

Open
davidjotte wants to merge 1 commit into
reallygood83:mainfrom
davidjotte:claude/admiring-shannon
Open

davidjotte wants to merge 1 commit into
reallygood83:mainfrom
davidjotte:claude/admiring-shannon

Conversation

@davidjotte

@davidjotte davidjotte commented Apr 19, 2026

Copy link
Copy Markdown

Summary

  • nlwflow note-wiki--url 옵션 추가 (--source 의 alias)
  • 두 옵션은 동일하게 동작하며 혼합 사용 가능
  • 기존 --source 동작에 영향 없음

Usage

note-wiki "Summarize the key points in this notebook" \
  --url "https://notebooklm.google.com/notebook/d681697d-1855-4818-bcaa-37df1db357dd"

Test plan

  • nlwflow note-wiki --help 에서 --url 옵션 확인
  • --url 로 URL 전달 시 plan.sources 에 포함되는지 확인
  • --source--url 동시 사용 시 모두 포함되는지 확인
  • 기존 tests/test_cli.py 통과 확인

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added a new --url command-line option as an alias for --source. Both options can now be used together, and their values will be combined when generating the wiki plan.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

A new CLI option --url was added as an alias for --source to the note-wiki command. The sources from both flags are now combined and passed to build_note_wiki_plan() using concatenation logic.

Changes

Cohort / File(s) Summary
CLI Source Option Enhancement
src/notebooklm_llm_wiki_flow/cli.py
Added --url option parameter as an alias for --source. Updated source handling to combine both source and url flags via sources=(source or []) + (url or []) when invoking build_note_wiki_plan().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A new path for URLs to hop,
--url alias, never to stop!
Sources combine in harmonious blend,
CLI options, around the bend! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a --url alias for --source in the note-wiki CLI command, which is precisely what the changeset implements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/notebooklm_llm_wiki_flow/cli.py (1)

211-214: ⚠️ Potential issue | 🟡 Minor

Mention --url in the "no sources" error message.

Since --url is now a supported alias, the error text should reference it so users discover the new flag when the validation fires.

✏️ Proposed tweak
     if not plan['sources'] and not dry_run:
         raise typer.BadParameter(
-            'No source URLs found. Include URLs in the prompt or pass one or more --source values.',
+            'No source URLs found. Include URLs in the prompt or pass one or more --source/--url values.',
         )
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/notebooklm_llm_wiki_flow/cli.py` around lines 211 - 214, The validation
raising typer.BadParameter when plan['sources'] is empty currently tells users
to pass "--source" but not the new alias; update the error message in the
conditional that checks "if not plan['sources'] and not dry_run" to mention both
"--source" and the supported alias "--url" (e.g., "pass one or more --source (or
--url) values") so users discover the new flag when the BadParameter is raised.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/notebooklm_llm_wiki_flow/cli.py`:
- Around line 211-214: The validation raising typer.BadParameter when
plan['sources'] is empty currently tells users to pass "--source" but not the
new alias; update the error message in the conditional that checks "if not
plan['sources'] and not dry_run" to mention both "--source" and the supported
alias "--url" (e.g., "pass one or more --source (or --url) values") so users
discover the new flag when the BadParameter is raised.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fda5c3a-0bc1-4709-a28d-c6e544040081

📥 Commits

Reviewing files that changed from the base of the PR and between 4e2aa26 and c80c150.

📒 Files selected for processing (1)
  • src/notebooklm_llm_wiki_flow/cli.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant