feat(cli): add --url alias for --source in note-wiki command - #3
davidjotte wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughA new CLI option Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/notebooklm_llm_wiki_flow/cli.py (1)
211-214:⚠️ Potential issue | 🟡 MinorMention
--urlin the "no sources" error message.Since
--urlis now a supported alias, the error text should reference it so users discover the new flag when the validation fires.✏️ Proposed tweak
if not plan['sources'] and not dry_run: raise typer.BadParameter( - 'No source URLs found. Include URLs in the prompt or pass one or more --source values.', + 'No source URLs found. Include URLs in the prompt or pass one or more --source/--url values.', )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/notebooklm_llm_wiki_flow/cli.py` around lines 211 - 214, The validation raising typer.BadParameter when plan['sources'] is empty currently tells users to pass "--source" but not the new alias; update the error message in the conditional that checks "if not plan['sources'] and not dry_run" to mention both "--source" and the supported alias "--url" (e.g., "pass one or more --source (or --url) values") so users discover the new flag when the BadParameter is raised.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/notebooklm_llm_wiki_flow/cli.py`:
- Around line 211-214: The validation raising typer.BadParameter when
plan['sources'] is empty currently tells users to pass "--source" but not the
new alias; update the error message in the conditional that checks "if not
plan['sources'] and not dry_run" to mention both "--source" and the supported
alias "--url" (e.g., "pass one or more --source (or --url) values") so users
discover the new flag when the BadParameter is raised.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6fda5c3a-0bc1-4709-a28d-c6e544040081
📒 Files selected for processing (1)
src/notebooklm_llm_wiki_flow/cli.py
Summary
nlwflow note-wiki에--url옵션 추가 (--source의 alias)--source동작에 영향 없음Usage
Test plan
nlwflow note-wiki --help에서--url옵션 확인--url로 URL 전달 시plan.sources에 포함되는지 확인--source와--url동시 사용 시 모두 포함되는지 확인tests/test_cli.py통과 확인🤖 Generated with Claude Code
Summary by CodeRabbit
--urlcommand-line option as an alias for--source. Both options can now be used together, and their values will be combined when generating the wiki plan.