Skip to content

Install ext-theme from requirements.txt #12264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 23, 2025

Move this Python package into our requirements workflow.

Closes #12140

Move this Python package into our requirements workflow.

Closes #12140
@humitos humitos requested a review from a team as a code owner June 23, 2025 16:19
@humitos humitos requested a review from stsewd June 23, 2025 16:19
@stsewd
Copy link
Member

stsewd commented Jun 23, 2025

Won't this affect production? We will be installing the latest version available on main instead of the version from the release.

Also, does this still allow us to hot reload locally? Like the changes from the local copy are taken into effect when running .org or .com locally

@ericholscher
Copy link
Member

ericholscher commented Jun 24, 2025

Yea, we should probably at least use a rel branch here, to ensure static releases. But I don't think this PR changes that in any way? We were already installing from main

@humitos
Copy link
Member Author

humitos commented Jun 25, 2025

I think both are correct here. We were installing from rel on production, but from main in development.

I kept the installation for development inside Dockerfile and I put the readthedocsext-theme package on those requirements where it's needed (testing, deploy)

Please, take another look and let me know. By the way, the PR that removes the Salt states is at https://github.com/readthedocs/readthedocs-ops/pull/1662

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Just to confirm, this doesn't change how we do it in Docker, where it's using a local mount, right?

@humitos
Copy link
Member Author

humitos commented Jun 26, 2025

Just to confirm, this doesn't change how we do it in Docker, where it's using a local mount, right?

Yeah, we are not changing that.

@@ -9,3 +9,6 @@ structlog-sentry
newrelic==10.7.0

ipython

# Theme for the dashboard (install from rel)
readthedocsext-theme @ git+https://github.com/readthedocs/ext-theme@rel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about .com? We need to install from relcorp there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New dashboard: install ext-theme from Python requirements
3 participants