-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Install ext-theme
from requirements.txt
#12264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Move this Python package into our requirements workflow. Closes #12140
Won't this affect production? We will be installing the latest version available on main instead of the version from the release. Also, does this still allow us to hot reload locally? Like the changes from the local copy are taken into effect when running .org or .com locally |
Yea, we should probably at least use a |
I think both are correct here. We were installing from I kept the installation for development inside Please, take another look and let me know. By the way, the PR that removes the Salt states is at https://github.com/readthedocs/readthedocs-ops/pull/1662 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. Just to confirm, this doesn't change how we do it in Docker, where it's using a local mount, right?
Yeah, we are not changing that. |
@@ -9,3 +9,6 @@ structlog-sentry | |||
newrelic==10.7.0 | |||
|
|||
ipython | |||
|
|||
# Theme for the dashboard (install from rel) | |||
readthedocsext-theme @ git+https://github.com/readthedocs/ext-theme@rel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about .com? We need to install from relcorp there.
Move this Python package into our requirements workflow.
Closes #12140