Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addons: load_when_embedded config #11765

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

humitos
Copy link
Member

@humitos humitos commented Nov 13, 2024

Add an extra addons config to decide whether or not force the injection of addons when the page is embedded (eg. iframe). By default, we are not loading addons if embedded.

Required by readthedocs/addons#415
Closes readthedocs/addons#412

@humitos humitos requested a review from a team as a code owner November 13, 2024 11:43
@humitos humitos requested a review from stsewd November 13, 2024 11:43
@humitos humitos requested review from agjohnson and removed request for stsewd November 13, 2024 11:44
@humitos humitos force-pushed the humitos/addons-embedded-http-header branch from 00bcd15 to 0fe2246 Compare November 13, 2024 12:03
Add an extra addons config to decide whether or not force the injection of
addons when the page is embedded (eg. iframe). By default, we are not loading
addons if embedded.

Required by readthedocs/addons#415
Closes readthedocs/addons#412
@humitos humitos changed the title Addons: add X-RTD-Load-Addons-When-Embedded HTTP header Addons: load_when_embedded config Nov 13, 2024
@humitos humitos force-pushed the humitos/addons-embedded-http-header branch from 0fe2246 to 7095954 Compare November 13, 2024 12:43
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a note on naming.

readthedocs/proxito/views/hosting.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication of fly-out and banners
2 participants