Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up front page copy #11705

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Clean up front page copy #11705

merged 3 commits into from
Oct 30, 2024

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Oct 22, 2024 •
edited by github-actions bot
Loading

📚 Documentation previews 📚

@ericholscher ericholscher requested a review from a team as a code owner October 22, 2024 21:01
humitos
humitos approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this clean up -- it has a little more marketing voice 😄

docs/user/index.rst Outdated Show resolved Hide resolved
plaindocs
plaindocs approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍 👍

docs/user/index.rst Outdated
Comment on lines 130 to 131
Treating documentation like code keeps your team in the same tools,
and your documentation up to date.
and makes keeping your docs updated easier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Treating documentation like code lets your team use tools they already know,
and makes keeping your docs updated easier.

docs/user/index.rst Outdated Show resolved Hide resolved
docs/user/index.rst Outdated Show resolved Hide resolved
docs/user/index.rst Show resolved Hide resolved
docs/user/index.rst Show resolved Hide resolved
docs/user/index.rst Show resolved Hide resolved
docs/user/index.rst Outdated Show resolved Hide resolved
@ericholscher ericholscher enabled auto-merge (squash) October 30, 2024 15:41
@ericholscher
Copy link
Member Author

I took applied most of the comments, and merging 👍

@ericholscher ericholscher merged commit d761c08 into main Oct 30, 2024
5 checks passed
@ericholscher ericholscher deleted the cleanup-front-page branch October 30, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@plaindocs plaindocs plaindocs approved these changes

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/advocacy

Assignees

@ericholscher ericholscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @plaindocs @humitos