Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: separate querysets from API V2 and V3 #11586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

API: separate querysets from API V2 and V3 #11586

wants to merge 4 commits into from
+39 −3

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Sep 5, 2024

This allows us to override just the v2 querysets on .com, since we want to share the same logic as .org for v3.

ref readthedocs/ext-theme#154

@stsewd stsewd marked this pull request as ready for review September 5, 2024 20:07
@stsewd stsewd requested a review from a team as a code owner September 5, 2024 20:07
ericholscher
ericholscher approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like this implementation a lot, since it makes API v3 the same across our sites, which feels like a huge simplification 💯

@humitos
Copy link
Member

humitos commented Sep 9, 2024

I actually like this implementation a lot, since it makes API v3 the same across our sites, which feels like a huge simplification 💯

Agreed! 👍🏼

@humitos
Copy link
Member

humitos commented Sep 10, 2024

Blocked by https://github.com/readthedocs/readthedocs-corporate/pull/1873

@humitos humitos added the Status: blocked Issue is blocked on another issue label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@ericholscher ericholscher ericholscher approved these changes

Assignees

@stsewd stsewd

Labels
Status: blocked Issue is blocked on another issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stsewd @humitos @ericholscher