Results of two runs of pre-commit run --all -- still fails due to "prospector"#11199
Closed
yarikoptic wants to merge 1 commit intoreadthedocs:mainfrom
Closed
Results of two runs of pre-commit run --all -- still fails due to "prospector"#11199yarikoptic wants to merge 1 commit intoreadthedocs:mainfrom
yarikoptic wants to merge 1 commit intoreadthedocs:mainfrom
Conversation
yarikoptic
added a commit
to yarikoptic/common
that referenced
this pull request
Mar 8, 2024
Those files are copied from other sources or edited by other tools and IMHO not subject for pre-commit handling. Refs: - readthedocs/readthedocs.org#11200 - readthedocs/readthedocs.org#11199
ericholscher
pushed a commit
to readthedocs/common
that referenced
this pull request
Oct 14, 2024
…ommit (#211) * Exclude vendor, .min.js, .svg, and static/*.js from pre-commit Those files are copied from other sources or edited by other tools and IMHO not subject for pre-commit handling. Refs: - readthedocs/readthedocs.org#11200 - readthedocs/readthedocs.org#11199 * Exclude migrations from isort, black, and pre-commit-hooks tuneups
Member
|
We migrated everything to ruff now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently either pre-commit was not "applied" throughout the codebase or may be versions of the tools are insufficiently pin'ed down -- that results in pre-commit introducing changes to the files if ran through the entire clean codebase. IMHO it is very undesired since could interfere with actual changes, making PRs harder to review etc.
note that it even applies to
vendor/folder.This PR is more of a demonstration of a problem than something to be merged, thus - making it draft.
📚 Documentation previews 📚
docs): https://docs--11199.org.readthedocs.build/en/11199/dev): https://dev--11199.org.readthedocs.build/en/11199/