Duplication of fly-out and banners #412
Labels
Needed: design decision
A core team decision is required
Comments
|
Thanks for reporting this issue. It took a quick look and I found that page performs a behind the scenes request to https://geovista.readthedocs.io/en/latest/_static/static_viewer.html with Since that URL is an HTML file, our CF worker is executed on that page and all the addons are added there as well. I don't have an answer to your question right now, but we will debugging/thinking a little more about this. |
humitos
added a commit
that referenced
this issue
Oct 29, 2024
Check if addons library is being loaded inside an iframe, and skip loading it. Closes #412
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this issue
Nov 13, 2024
Add an extra HTTP header to decide whether or not force the injection of addons when the page is embedded (eg. iframe). By default, we are not loading addons if embedded. Required by readthedocs/addons#415 Closes readthedocs/addons#412
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this issue
Nov 13, 2024
Add an extra addons config to decide whether or not force the injection of addons when the page is embedded (eg. iframe). By default, we are not loading addons if embedded. Required by readthedocs/addons#415 Closes readthedocs/addons#412
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this issue
Nov 13, 2024
Add an extra addons config to decide whether or not force the injection of addons when the page is embedded (eg. iframe). By default, we are not loading addons if embedded. Required by readthedocs/addons#415 Closes readthedocs/addons#412
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for the new RTD
addons, they're pretty awesome 💯However, I have noticed now that the new
addonsare default, the fly-out is being replicated within an interactive tab in our geovista project (docs)e.g., see this FVCOM Bathymetry interactive gallery example shown below (ensure to click the
Interactive Scenetab) and notice the duplicated fly-out within the window. Note that, alladdonsare duplicated e.g., version banners at alIs there something that you can fix on your side to prevent this happening?
This wasn't an issue previously.
Many thanks 🍻
The text was updated successfully, but these errors were encountered: