Add Vale to RTD pre-commit #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved the common vale files over here, and symlinked them into org/business |
|
The original changes were described here: readthedocs/readthedocs.org#12258 |
agjohnson
reviewed
Jun 20, 2025
There was a problem hiding this comment.
I updated this file in a PR, so we should reflect that here. But note that the filename is incorrect, it needs to be .yml for vale to find it.
agjohnson
reviewed
Jun 20, 2025
| @@ -0,0 +1,9 @@ | |||
| extends: substitution | |||
| message: Use 'Single sign-on' instead of '%s' | |||
There was a problem hiding this comment.
Also note the message double substitution is important. Very silly this isn't just a default for the message attr.
Suggested change
| message: Use 'Single sign-on' instead of '%s' | |
| message: Use '%s' instead of '%s' |
agjohnson
reviewed
Jun 20, 2025
| Single Sign on: Single sign-on | ||
| single sign-on: Single sign-on | ||
| single Sign-On: Single sign-on | ||
| single Sign on: Single sign-on |
There was a problem hiding this comment.
And this is substituting a capitalized version still. I fixed this using case insensitivity and exceptions:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs readthedocs/readthedocs.org#12257
Downstrream: