This repository was archived by the owner on May 7, 2025. It is now read-only.
Fix conversion of epub2/ncx TOCs to <ol> form#98
Open
chine wants to merge 1 commit intoreadium:masterfrom
Open
Fix conversion of epub2/ncx TOCs to <ol> form#98chine wants to merge 1 commit intoreadium:masterfrom
chine wants to merge 1 commit intoreadium:masterfrom
Conversation
Contributor
|
Defer for now. It targets master and we need a reproducible case. |
Member
|
This PR indeed targets the master branch instead of develop. Furthermore, the file // Description: Constructs an html representation of NCX navPoints, based on an object of navPoint information
// Rationale: This is a recursive method, as NCX navPoint elements can nest 0 or more of themselves as children
function addNavPointElements($navPointDOM, $ol) {
// Add the current navPoint element to the TOC html
var navText = $navPointDOM.children("navLabel").text().trim();
var navHref = $navPointDOM.children("content").attr("src");
var $navPointLi = $('<li class="nav-elem"></li>').append(
$('<a></a>', { href: navHref, text: navText })
);
// Append nav point info
$ol.append($navPointLi);
// Append ordered list of nav points
if ($navPointDOM.children("navPoint").length > 0 ) {
var $newLi = $("<li></li>");
var $newOl = $("<ol></ol>");
$.each($navPointDOM.children("navPoint"), function (navIndex, navPoint) {
$newOl.append(addNavPointElements($(navPoint), $newOl));
});
$newLi.append($newOl);
$ol.append($newLi);
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: Issue 97