Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure graphiql IDE to use the graphQLEndpoint #60

Closed
wants to merge 2 commits into from
Closed

Configure graphiql IDE to use the graphQLEndpoint #60

wants to merge 2 commits into from

Conversation

akagomez
Copy link

@akagomez akagomez commented Aug 10, 2017

I had assumed that when I set my config.graphQLEndpoint via config.setGraphQLEndpoint() that the graphiql IDE would continue to be served at /graphql and instead connect to my configured graphQLEndpoint.

Upon further examination, it seems the only way the graphiql IDE works is if:

config.graphQLEndpoint === config.graphQLServer.endpoint

This PR attempts to address that.

Unfortunately, even with this fix the graphql server is still served at POST ${config.graphQLServer.endpoint} despite the modified graphQLEndpoint.

Aside: This kit has drastically reduced the react/redux/graphql learning curve for me - at least it feels that way based on my past intimidation/procrastination. I'm overwhelmingly appreciative of the effort that's gone into it. Thank you!

Make the graphiql IDE usable with an external GraphQL endpoint.
Add trailing comma.
@leebenson
Copy link
Member

Thanks for the PR and the nice words, @akagomez.

I'm going to release a fix in the next version that allows GraphiQL to be integrated even when setting an external GraphQL endpoint, so I'll go ahead and close this since the issue will be fixed.

Will post an announcement here when released, too. Should be done today.

@leebenson leebenson closed this Aug 17, 2017
@leebenson
Copy link
Member

Released in https://github.com/reactql/kit/releases/tag/2.3.0 -- see the release notes for details on the changes/fixes.

npm i -g reactql to bump to CLI v4.2.0 with the latest kit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants