Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proof of concept fix for #121
I want to collect some feedback with regards to the element id namespacing and the general approach to access these JSON blobs.
document.getElementById().innerHTML
is used here but there are many options to select them(ids, classes, data attributes).I'd also like to talk about line 45 and its surroundings now, which is pretty dirty. Doing what is basically abstracted
eval
'ing(but I didn't want to include this change immediately):My suggestion is to replace this script tag with another JSON blob containing our keys and moving all the window rehydration logic over into
kit/entry/browser.js
, check out my approach to that over at https://github.com/klarstrup/kit/compare/json-window...klarstrup:json-window-clean?expand=1 and tell me what you think.