Add polyfill to browser entry point #119
Closed
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
For us, we also needed to change line 36 in browser_dev.js to
So that babel-polyfill would come first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this polyfill, the kit will work in "server-render" mode (
:8081) for older browsers (tested IE11 in Edge and IE10 mode, didn't dare to go any lower)."hot-reloading" mode still doesn't work, though. There I run into this issue.
I tried changing the order of entry as commented on that issue, but new errors just keep creeping up.
Nonetheless, when building for production, server-rendering is enabled anyway, so this PR will make the kit work for more browsers in production.