Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPVEYOR] Create appveyor.yml #2

Conversation

SergeGautherie
Copy link
Contributor

@SergeGautherie SergeGautherie commented May 29, 2018

To leverage this PR, a ReactOS admin should register sysreg2 on AppVeyor.

@SergeGautherie SergeGautherie force-pushed the SergeGautherie/PRonly_AppVeyor_create-yml branch from e29718d to f269624 Compare May 31, 2018 02:32
@learn-more
Copy link
Member

What is the purpose of this PR?
What do we gain by running this in appveyor?

@SergeGautherie SergeGautherie force-pushed the SergeGautherie/PRonly_AppVeyor_create-yml branch from f269624 to 2b89dc3 Compare June 6, 2018 01:53
@SergeGautherie
Copy link
Contributor Author

@learn-more, I am puzzled by your questions,
as I assume adding "Continuous Integration" speaks for itself, especially as we already have it on ReactOS itself.

@sanchaez
Copy link
Member

sanchaez commented Jun 6, 2018

We could use TravisCI or other things, why AppVeyor?

@SergeGautherie
Copy link
Contributor Author

We could use TravisCI or other things, why AppVeyor?

AppVeyor is already used for ReactOS itself and is the service I use.
Anyone else can add support for other CI service(s) too.

Sysreg2 project admin may use whichever service(s) is preferred, or none even...

@learn-more learn-more merged commit c69e417 into reactos:master Jun 14, 2018
@SergeGautherie SergeGautherie deleted the SergeGautherie/PRonly_AppVeyor_create-yml branch June 14, 2018 21:00
@SergeGautherie
Copy link
Contributor Author

@HeisSpiter, why did you revert this commit in 24b7ae6?

@HeisSpiter
Copy link
Member

Now that travis CI is configured, there's no point of keeping AppVeyor which was never configured with the repository.
As you wrote:

Sysreg2 project admin may use whichever service(s) is preferred

Job done ;-)

@SergeGautherie
Copy link
Contributor Author

Job done ;-)

Well, you and I obviously do not have the same point of view:
while I did mean adding Travis CI, and even enabling it, would be fine,
I never meant that should trigger unsupporting community people, like me, who do use AppVeyor :-(

In other words, you did explicitly break my builds (as in making them more complicated to set up), removed that "template", and are implicitly trying to "force" me to use Travis CI:
that is exactly the kind of decisions I call "developer-centric, community-excluding" 👎

Unless you could tell me what harm that file would be causing, that I totally missed?

@learn-more
Copy link
Member

That is what happens if you give vague answers when a developer asks what the point of a PR is.

You said:
'as I assume adding "Continuous Integration" speaks for itself, especially as we already have it on ReactOS itself.'

instead of:
'I want to use CI on my own branch, and this change makes it easier.'

Consider that you are talking to humans, not to machines, so we do not ask for something that we can google (what is CI), but we ask for the reasoning behind it.

@HeisSpiter
Copy link
Member

No overreaction, please. Feel free to use whatever you want in your local branch. I see you already have a fully configured AppVeyor in your branch. That's perfect, that will even be easier for you to maintain as there will be no conflicts given the file only exists in your branch.

@SergeGautherie
Copy link
Contributor Author

if you give vague answers

I wrote "I am puzzled by your questions",
so I believe my answers were no more vague than asked questions seemed to be to me...

Later, I even wrote "AppVeyor [...] is the service I use",
which seems rather explicit to me!

I too am a human, not a machine: as I noted, I did not understand/expect such questions, as the answers seemed so obvious to me :-/

Eventually, you committed this PR, so I assumed the reasoning had become clear enough.


local branch

There were no conflicts so far and I did not expect "any" in the future: at least, no more than on 'reactos' repository.
And, no, endlessly maintaining a local commit does not seem easier to me nor more useful to the community: quite the opposite.
As in: could you un-revert this PR?

My complain would be "I" was not even asked/warned before reverting this PR.
Especially, "could you tell me what harm that file would be causing", even if afterward now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants