-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APPVEYOR] Create appveyor.yml #2
[APPVEYOR] Create appveyor.yml #2
Conversation
e29718d
to
f269624
Compare
What is the purpose of this PR? |
f269624
to
2b89dc3
Compare
@learn-more, I am puzzled by your questions, |
We could use TravisCI or other things, why AppVeyor? |
|
@HeisSpiter, why did you revert this commit in 24b7ae6? |
Now that travis CI is configured, there's no point of keeping AppVeyor which was never configured with the repository.
Job done ;-) |
Well, you and I obviously do not have the same point of view: In other words, you did explicitly break my builds (as in making them more complicated to set up), removed that "template", and are implicitly trying to "force" me to use Travis CI: Unless you could tell me what harm that file would be causing, that I totally missed? |
That is what happens if you give vague answers when a developer asks what the point of a PR is. You said: instead of: Consider that you are talking to humans, not to machines, so we do not ask for something that we can google (what is CI), but we ask for the reasoning behind it. |
No overreaction, please. Feel free to use whatever you want in your local branch. I see you already have a fully configured AppVeyor in your branch. That's perfect, that will even be easier for you to maintain as there will be no conflicts given the file only exists in your branch. |
I wrote "I am puzzled by your questions", Later, I even wrote "AppVeyor [...] is the service I use", I too am a human, not a machine: as I noted, I did not understand/expect such questions, as the answers seemed so obvious to me :-/ Eventually, you committed this PR, so I assumed the reasoning had become clear enough.
There were no conflicts so far and I did not expect "any" in the future: at least, no more than on 'reactos' repository. My complain would be "I" was not even asked/warned before reverting this PR. |
To leverage this PR, a
ReactOS
admin should registersysreg2
onAppVeyor
.