Update code formatting on useTransition.md #6413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
lunaleaps
reviewed
Nov 6, 2023
| import './styles.css'; | ||
| import React, { StrictMode } from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
| import "./styles.css"; |
Contributor
There was a problem hiding this comment.
Are double-quoting these? I'm seeing single-quotes elsewhere
Contributor
Author
There was a problem hiding this comment.
This is what CodeSandbox does by default on save
codesandbox-double-quote-on-save.mov
Contributor
There was a problem hiding this comment.
Ohoo I see, do you mind if we keep it single? This is how we format code at Meta and I also see most of our docs already use single quotes. I think we need some light-weight markdown formatting to start enforcing this. I'm wondering if we can turn it on with most formatting disabled. I looked into it before but I think this might be possible
lunaleaps
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.