Skip to content

feat:添加maven插件,可将proto文件自动生成java文件;补充了3个grpc的流式调用例子。 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZakiFan
Copy link
Member

@ZakiFan ZakiFan commented Feb 5, 2021

了解了GRPC的使用方式。后面会把GRPC和Netty了解清楚。

@pinxiong
Copy link
Member

pinxiong commented Feb 6, 2021

@ZakiFan Thanks for your PR. It sounds good. However, there are several suggesstions for you as follows

  • There are four kinds of service method (Unary RPC, Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC). Now, HelloWorld is the Unary RPC, so you'd better divide GrpcServer and GrpcClient to three different kinds of Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC. If you do, it will make others understand better.

  • Keep the same code style, such as all of ***Server.java and ***Client.java are in the package io.grpc.examples

  • The rest of three kinds of server method are built by hello_streaming.proto and route_guide.proto, which are the official examples in grpc-java project, so you'd better use these to build the rest of server methods, because official examples can illustrate all features of grpc-java better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants