build: update build to preserve modules and use @rollup/plugin-typescript #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 841f273:
|
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
025bb90
to
3c58be3
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
3c58be3
to
62a8838
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
62a8838
to
7c53e29
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
7c53e29
to
b4eec70
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
b4eec70
to
40c8e58
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
40c8e58
to
187c2ef
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
187c2ef
to
8d06039
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
8d06039
to
3587ed2
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
07d10e2
to
80c79f8
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
80c79f8
to
76a71a9
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
76a71a9
to
fea305a
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
fea305a
to
a6f55dc
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
a6f55dc
to
f2499fd
Compare
WesSouza
changed the title
WesSouza
commented
Aug 5, 2022
rollup.config.js
Outdated
| input: './src/index.ts', | ||
| { | ||
| ...baseBundle, | ||
| input: ['./src/index.ts', './src/types.tsx'], |
There was a problem hiding this comment.
@arturbien @luizbaldi apparently types breaking on the consumers was caused by types not being exported.
…ript This changes the main output to also preserve modules, allowing tree shaking when users build their projects. This also replaces rollup-plugin-dts with the more traditional @rollup/plugin-typescript, which exports type declarations for individual files fixing issues with themes imports.
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
f2499fd
to
841f273
Compare
WesSouza
force-pushed
the
build-plugin-typescript
branch
from
801f349
to
841f273
Compare
arturbien
approved these changes
Aug 7, 2022
|
🎉 This PR is included in version 4.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the main output to also preserve modules, allowing tree shaking when users build their projects.
This also replaces rollup-plugin-dts with the more traditional @rollup/plugin-typescript, which exports type declarations for individual files fixing issues with themes imports.
It also adds missing
displayNametoSelect,Toolbar,TreeViewandWindowHeader, as well as improves the return type generics ofSelectandTreeView.Closes #346, #347.