feat(themes): add Windows theme adapter #221
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arturbien/react95/g9vu8slhe |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0ed55b:
|
|
@tpenguinltg at first glance it looks really good. Also the new theme is super cute. I will take a closer look at the PR tomorrow. Thanks a lot |
src/common/utils/index.js
Outdated
| name, | ||
|
|
||
| anchor: HotTrackingColor, | ||
| anchorVisited: GrayText, // no Windows equivalent |
There was a problem hiding this comment.
let's map anchorVisited to HotTrackingColor as well then. This way links will always stay the same color
There was a problem hiding this comment.
That makes sense. I've made the change.
Add a util function mapFromWindowsTheme that transforms a Windows theme into a React95 theme.
"Peggy's Pastels" by tPenguinLTG https://www.deviantart.com/tpenguinltg/art/Peggy-s-Pastels-505540096
tpenguinltg
force-pushed
the
feat/windows-theme-mapping
branch
from
e5fc7bf to
f0ed55b
Compare
|
@tpenguinltg great work. do you plan to also open a PR with additional converted themes? |
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@arturbien I do. We can discuss in #213 which one's you'd like to have and I'll also curate a list myself for the ones I think would be good, then I can go ahead and convert the ones we agree on. |
This PR adds a new util function called
mapFromWindowsThemethat takes a theme name, an object representing a Windows theme, and a flag indicating whether gradients should be used for the title bars.The Windows theme object has Windows property names as keys and CSS colours as values (as strings). The
rgbformat allows for the simplest conversion since values in a Windows theme are already in decimal RGB, but any valid CSS colour can be used.A theme called
peggysPastelshas been added to showcase the new function. The non-gradient version is the default export, but a gradient version is exported with aGsuffix. Theme from DeviantArt.Closes #212