Skip to content

Revert use of built-in React Native logical CSS#342

Merged
necolas merged 3 commits into
mainfrom
native/revert-logical-css
Jul 21, 2025
Merged

Revert use of built-in React Native logical CSS#342
necolas merged 3 commits into
mainfrom
native/revert-logical-css

Conversation

@necolas

@necolas necolas commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Revert to fix regression

@meta-cla meta-cla Bot added the cla signed label Jul 21, 2025
@github-actions

github-actions Bot commented Jul 21, 2025

Copy link
Copy Markdown

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,514 2,514 1.00
· minified 8,691 8,691 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 16,168 16,325 1.01 +
· minified 60,400 61,175 1.01 +

@github-actions

github-actions Bot commented Jul 21, 2025

Copy link
Copy Markdown

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,125,058 1,124,352 1.00 -
· small with units 422,739 418,839 0.99 -
· small with variables 663,466 654,429 0.99 -
· several small 311,030 307,899 0.99 -
· large 203,815 203,003 1.00 -
· large with polyfills 142,687 144,146 1.01 +
· complex 98,656 98,680 1.00 +
· unsupported 213,987 212,394 0.99 -
css.createTheme
· simple theme 227,977 227,731 1.00 -
· polyfill theme 211,121 211,160 1.00 +
css.props
· small 282,904 234,417 0.83 !!
· small with units 223,340 193,103 0.86 !!
· small with variables 113,528 104,276 0.92 !!
· small with variables of units 79,568 74,791 0.94 !!
· large 120,875 98,371 0.81 !!
· large with polyfills 41,504 37,557 0.90 !!
· complex 25,399 23,802 0.94 !!
· unsupported 179,408 144,730 0.81 !!
· simple merge 185,494 164,055 0.88 !!
· wide merge 19,332 18,052 0.93 !!
· deep merge 18,833 17,625 0.94 !!
· themed merge 36,805 32,070 0.87 !!

@necolas necolas force-pushed the native/revert-logical-css branch from e9f0e98 to d9c9744 Compare July 21, 2025 20:32
@necolas necolas changed the title Fix the content-box polyfill to account for logical CSS Revert use of built-in React Native logical CSS Jul 21, 2025
@necolas necolas merged commit 0a68208 into main Jul 21, 2025
8 checks passed
@necolas necolas deleted the native/revert-logical-css branch July 25, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant