Skip to content

Only set userSelect:auto on anchor tags (native) #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necolas merged 1 commit into from
Jun 27, 2025
Merged

Only set userSelect:auto on anchor tags (native) #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions packages/react-strict-dom/src/native/modules/createStrictDOMTextComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { errorMsg } from '../../shared/logUtils';
import { mergeRefs } from '../../shared/mergeRefs';
import { useNativeProps } from './useNativeProps';
import { useStrictDOMElement } from './useStrictDOMElement';
import * as stylex from '../stylex';

type StrictProps = $ReadOnly<{
...StrictPropsOriginal,
Expand All @@ -31,7 +30,7 @@ function hasElementChildren(children: mixed): boolean {

export function createStrictDOMTextComponent<T, P: StrictProps>(
tagName: string,
_defaultProps?: P
defaultProps?: P
): component(ref?: React.RefSetter<T>, ...P) {
const component: React.AbstractComponent<P, T> = React.forwardRef(
function (props, forwardedRef) {
Expand All @@ -44,10 +43,6 @@ export function createStrictDOMTextComponent<T, P: StrictProps>(
* Resolve global HTML and style props
*/

const defaultProps = {
style: [_defaultProps?.style, styles.userSelectAuto]
};

const { customProperties, nativeProps, inheritableStyle } =
useNativeProps(defaultProps, props, {
provideInheritableStyle:
Expand Down Expand Up @@ -151,9 +146,3 @@ export function createStrictDOMTextComponent<T, P: StrictProps>(
component.displayName = `html.${tagName}`;
return component;
}

const styles = stylex.create({
userSelectAuto: {
userSelect: 'auto'
}
});
1 change: 0 additions & 1 deletion packages/react-strict-dom/tests/__snapshots__/compat-test.native.js.snap-native
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ exports[`<compat.native> nested: nested 1`] = `
"boxSizing": "content-box",
"color": "red",
"position": "static",
"userSelect": "auto",
}
}
>
Expand Down
Loading