Skip to content

Remove no-op MaintainVisibleScrollPositionHelper#updateScrollPosition() #56535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javache wants to merge 1 commit into from
Closed

Remove no-op MaintainVisibleScrollPositionHelper#updateScrollPosition() #56535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ...roid/src/main/java/com/facebook/react/views/scroll/MaintainVisibleScrollPositionHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,6 @@ internal class MaintainVisibleScrollPositionHelper<ScrollViewT>(
uIManager.removeUIManagerEventListener(this)
}

/**
* Update the scroll position of the managed ScrollView. This should be called after layout has
* been updated.
*
* On Fabric this will be called internally in `didMountItems`.
*/
fun updateScrollPosition() = Unit

private fun updateScrollPositionInternal() {
val config = config ?: return
val firstVisibleViewRef = firstVisibleViewRef ?: return
Expand Down
2 changes: 0 additions & 2 deletions ...ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactHorizontalScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,8 +1681,6 @@ public void onLayoutChange(
// does not work in RTL.
if (v.getLayoutDirection() == LAYOUT_DIRECTION_RTL) {
adjustPositionForContentChangeRTL(left, right, oldLeft, oldRight);
} else if (mMaintainVisibleContentPositionHelper != null) {
mMaintainVisibleContentPositionHelper.updateScrollPosition();
}
ReactScrollViewHelper.emitLayoutChangeEvent(this);
}
Expand Down
6 changes: 1 addition & 5 deletions ...ive/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactNestedScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<dd8221f4b150b4b3bec3dafd4b745482>>
* @generated SignedSource<<74209bb4a44619a1ce16d68cfeeb0653>>
*/

/**
Expand Down Expand Up @@ -1466,10 +1466,6 @@ public void onLayoutChange(
return;
}

if (mMaintainVisibleContentPositionHelper != null) {
mMaintainVisibleContentPositionHelper.updateScrollPosition();
}

if (isShown() && isContentReady()) {
int currentScrollY = getScrollY();
int maxScrollY = getMaxScrollY();
Expand Down
4 changes: 0 additions & 4 deletions ...ct-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1458,10 +1458,6 @@ public void onLayoutChange(
return;
}

if (mMaintainVisibleContentPositionHelper != null) {
mMaintainVisibleContentPositionHelper.updateScrollPosition();
}

if (isShown() && isContentReady()) {
int currentScrollY = getScrollY();
int maxScrollY = getMaxScrollY();
Expand Down
Loading