Skip to content

Fix unused parameter warnings in ShadowNode.h (#56519) #56519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
Closed

Fix unused parameter warnings in ShadowNode.h (#56519) #56519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
ShadowNode(const ShadowNode &shadowNode) noexcept = delete;
ShadowNode &operator=(const ShadowNode &other) noexcept = delete;

virtual ~ShadowNode() override = default;
~ShadowNode() override = default;

/*
* Clones the shadow node using the ShadowNode's ComponentDescriptor.
Expand Down Expand Up @@ -118,7 +118,7 @@ class ShadowNode : public Sealable, public DebugStringConvertible, public jsi::N
* Called, once a fully derived ShadowNode clone has been created via
* ComponentDescriptor::cloneShadowNode.
*/
virtual void completeClone(const ShadowNode &sourceShadowNode, const ShadowNodeFragment &fragment) {}
virtual void completeClone(const ShadowNode & /* sourceShadowNode */, const ShadowNodeFragment & /* fragment */) {}

#pragma mark - Getters

Expand Down
6 changes: 3 additions & 3 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4613,14 +4613,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down Expand Up @@ -5477,7 +5477,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
public virtual bool getIsLayoutClean() const override;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
public virtual void dirtyLayout() override;
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
Expand Down
6 changes: 3 additions & 3 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4604,14 +4604,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down Expand Up @@ -5468,7 +5468,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
public virtual bool getIsLayoutClean() const override;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
public virtual void dirtyLayout() override;
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
Expand Down
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7197,14 +7197,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down
4 changes: 2 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7188,14 +7188,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down
6 changes: 3 additions & 3 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3173,14 +3173,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down Expand Up @@ -3892,7 +3892,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
public virtual bool getIsLayoutClean() const override;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
public virtual void dirtyLayout() override;
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
Expand Down
6 changes: 3 additions & 3 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3164,14 +3164,14 @@ class facebook::react::ShadowNode : public facebook::react::Sealable, public fac
public std::shared_ptr<facebook::react::ShadowNode> cloneTree(const facebook::react::ShadowNodeFamily& shadowNodeFamily, const std::function<std::shared_ptr<facebook::react::ShadowNode>(const facebook::react::ShadowNode& oldShadowNode)>& callback) const;
public using AncestorList = std::vector<std::pair<std::reference_wrapper<const facebook::react::ShadowNode>, int>>;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child);
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment);
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&);
public virtual void replaceChild(const facebook::react::ShadowNode& oldChild, const std::shared_ptr<const facebook::react::ShadowNode>& newChild, size_t suggestedIndex = std::numeric_limits<size_t>::max());
public virtual ~ShadowNode() override = default;
public void sealRecursive() const;
public void setMounted(bool mounted) const;
public void setRuntimeShadowNodeReference(const std::shared_ptr<facebook::react::ShadowNodeWrapper>& runtimeShadowNodeReference) const;
public void transferRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode, const facebook::react::ShadowNodeFragment& fragment) const;
public void updateRuntimeShadowNodeReference(const std::shared_ptr<const facebook::react::ShadowNode>& destinationShadowNode) const;
public ~ShadowNode() override = default;
}

class facebook::react::ShadowNodeFamily : public facebook::jsi::NativeState {
Expand Down Expand Up @@ -3883,7 +3883,7 @@ class facebook::react::YogaLayoutableShadowNode : public facebook::react::Layout
public using Shared = std::shared_ptr<const facebook::react::YogaLayoutableShadowNode>;
public virtual bool getIsLayoutClean() const override;
public virtual void appendChild(const std::shared_ptr<const facebook::react::ShadowNode>& child) override;
public virtual void completeClone(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment) override;
public virtual void completeClone(const facebook::react::ShadowNode&, const facebook::react::ShadowNodeFragment&) override;
public virtual void dirtyLayout() override;
public virtual void layout(facebook::react::LayoutContext layoutContext) override;
public virtual void layoutTree(facebook::react::LayoutContext layoutContext, facebook::react::LayoutConstraints layoutConstraints) override;
Expand Down
Loading