Skip to content

Temporary change to test blocking signal #56504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 2 commits into from
+2,629 −1,761
Closed

Temporary change to test blocking signal #56504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b596fd9
Change failing C++ api validation signal to blocking
j-piasecki Apr 20, 2026
d303b59
Temporary change to test blocking signal
j-piasecki Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/validate-cxx-api-snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ jobs:
run: pip install doxmlparser natsort pyyaml
- name: Validate C++ API snapshots
shell: bash
continue-on-error: true
run: yarn cxx-api-validate --output-dir /tmp/cxx-api-snapshots
- name: Upload C++ API snapshots
if: always()
uses: actions/upload-artifact@v6
with:
name: cxx-api-snapshots
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ class ShadowTree final {
*/
void mergeReactRevision() const;

void noop() const {};

private:
constexpr static ShadowTreeRevision::Number INITIAL_REVISION{0};

Expand Down
739 changes: 443 additions & 296 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

739 changes: 443 additions & 296 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

727 changes: 435 additions & 292 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

727 changes: 435 additions & 292 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

727 changes: 435 additions & 292 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

727 changes: 435 additions & 292 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop

Large diffs are not rendered by default.

Loading