Skip to content

RN: Return zero measure values in measure API when ReactRootView cannot be found in view hierarchy #51994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coiggahou2002 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RN: Return zero measure values in measure API when ReactRootView cannot be found in view hierarchy #51994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-native/React/Modules/RCTUIManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,6 +1381,14 @@ - (void)_dispatchPropsDidChangeEvents
rootView = rootView.superview;
}

// It is possible that the RootView can't be found because this view is no longer on the screen
// and has been removed by clipping (eg. by setting the `removeClippedSubview` prop to `true`)
if (![rootView isReactRootView]) {
RCTLogError(@"measure cannot find react root view for view with tag #%@", reactTag);
callback(@[ @(0), @(0), @(0), @(0), @(0), @(0) ]);
return;
}

// By convention, all coordinates, whether they be touch coordinates, or
// measurement coordinates are with respect to the root view.
CGRect frame = view.frame;
Expand Down