Fix -Wnullable-to-nonnull-conversion for Xcode 26.4 (#56518)#56518
Closed
fkgozali wants to merge 1 commit into
Closed
Fix -Wnullable-to-nonnull-conversion for Xcode 26.4 (#56518)#56518fkgozali wants to merge 1 commit into
fkgozali wants to merge 1 commit into
Conversation
|
@fkgozali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101668743. |
meta-cla
Bot
added
the
CLA Signed
meta-codesync
Bot
changed the title
fkgozali
force-pushed
the
export-D101668743
branch
from
27401dc to
f253c7d
Compare
Summary: Pull Request resolved: #56518 The fix adds null-coalescing fallbacks (`?: ""`) for UTF8String calls that return `const char * _Nullable` but are passed to `std::string` constructors or C++ functions expecting `const char * _Nonnull`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D101668743
fkgozali
force-pushed
the
export-D101668743
branch
from
f253c7d to
0394b14
Compare
Collaborator
|
This pull request was successfully merged by @fkgozali in b2aa694 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in b2aa694. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The fix adds null-coalescing fallbacks (
?: "") for UTF8String calls that returnconst char * _Nullablebut are passed tostd::stringconstructors or C++ functions expectingconst char * _Nonnull.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D101668743